Skip to content

Conversation

yf-yang
Copy link

@yf-yang yf-yang commented Sep 6, 2025

Closes #2778

@yf-yang
Copy link
Author

yf-yang commented Sep 6, 2025

@DouweM

@DouweM DouweM self-assigned this Sep 8, 2025
Copy link
Collaborator

@DouweM DouweM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yf-yang
Copy link
Author

yf-yang commented Sep 9, 2025

Sure, will get back to you in one or two days

@yf-yang
Copy link
Author

yf-yang commented Sep 11, 2025

Hmmm, is this test failure relevant?
Also, I am not sure if the coverage is enough as I don't have a deepseek/openrouter key

@yf-yang yf-yang requested a review from DouweM September 11, 2025 17:03
@DouweM
Copy link
Collaborator

DouweM commented Sep 11, 2025

@yf-yang The test failure indicate that 'response_prefix': None should be added to the output's that's compared in that test.

Hmmm, is this test failure relevant? Also, I am not sure if the coverage is enough as I don't have a deepseek/openrouter key

I have both keys so I can look at that today or tomorrow. Thanks for all your work here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support prefill by ending history with ModelResponse
2 participants