Fix a false positive for not-an-iterable in Pylint.
#2830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦ context. Closes pylint-dev/pylint#8985 Closes pylint-dev/pylint#10558
|
I'm never terribly confident when touching the astroid codebase but it seems to fix the issue at least! |
for more information, see https://pre-commit.ci
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2830 +/- ##
=======================================
Coverage 93.35% 93.36%
=======================================
Files 91 91
Lines 11113 11119 +6
=======================================
+ Hits 10375 10381 +6
Misses 738 738
Flags with carried forward coverage won't be shown. Click here to find out more.
π New features to boost your workflow:
|
Co-authored-by: Pierre Sassoulas <[email protected]>
DanielNoord
previously approved these changes
Sep 23, 2025
Mention what is newly supported in Astroid. Co-authored-by: DaniΓ«l van Noord <[email protected]>
I'll take your advice! Do you like the wording now? |
DanielNoord
approved these changes
Sep 26, 2025
DanielNoord
temporarily deployed
to
Backport
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Fix a false positive for
not-an-iterablein anExceptionGroupcontext.Refs #XXXX
Closes pylint-dev/pylint#8985
Closes pylint-dev/pylint#10558