Support isinstance constraints in inference
#2846
Conversation
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2846 +/- ##
==========================================
+ Coverage 93.35% 93.39% +0.04%
==========================================
Files 92 92
Lines 11190 11208 +18
==========================================
+ Hits 10446 10468 +22
+ Misses 744 740 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
π New features to boost your workflow:
|
|
Seems like test coverage is lacking. Shouldn't be an issue to get it up to 100%, but I would like a review first to see if this implementation makes sense. |
jacobtylerwalls
left a comment
jacobtylerwalls
left a comment
There was a problem hiding this comment.
Wonderful!
As we do more of these, it would be nice to add a CI step that installs pylint and runs the primer. I had an experiment (work in progress) at jacobtylerwalls#157 and
pylint-dev/pylint@main...jacobtylerwalls:pylint:run-with-custom-astroid. Something for later.
DanielNoord
left a comment
DanielNoord
left a comment
There was a problem hiding this comment.
@jacobtylerwalls Should this be merged for 4.0.0 considering we already released a RC? Feels like a big change to include after a RC.
|
I wondered as well, happy to wait for 4.1. Let's release 4.0 final tomorrow in that case. |
Let's do so, especially as we haven't tested this with |
Pierre-Sassoulas
left a comment
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
This is neat ! Glad to see that the constraint api is getting some love.
Pierre-Sassoulas
added
the
Blocked π§
zenlyj
dismissed stale reviews from Pierre-Sassoulas and jacobtylerwalls
via
b3b9dd4
zenlyj
force-pushed
the
constraint-type
branch
from
e5217a2 to
b3b9dd4
Compare
zenlyj
force-pushed
the
constraint-type
branch
from
b3b9dd4 to
010503c
Compare
zenlyj
force-pushed
the
constraint-type
branch
from
010503c to
16032d5
Compare
jacobtylerwalls
removed
the
Blocked π§
|
Hey @zenlyj π I think this is mergeable. What do we need for the pylint job to pass, do we need a separate PR to unblock, or is it just a rebase? |
|
This pylint issue I fixed on main then forgot I fixed it and fixed it again on maintenance 2 week later... so I can tell you this is just a rebase π (Need 325ebf6) |
|
In that case, I'll just pull it in π |
4 participants
Type of Changes
Description
These changes implements the constraint interface to add a new constraint -
TypeConstraintto improve the accuracy of inference for objects used in type-narrowing guards.Currently, the implementation only supports the
isinstancepattern, but it should be relatively straightforward to extend it to support the negated case (not isinstance) in the future.To determine whether an object is an instance of the given types, the implementation reuses existing inference mechanism for
isinstanceinbrains.Refs pylint-dev/pylint#1162
Refs pylint-dev/pylint#4635
Refs pylint-dev/pylint#10469