Fix mean, var and std for XTensorVariables #1533
Conversation
ricardoV94
force-pushed
the
broadcast_not_a_method
branch
from
d89351c to
33e831a
Compare
|
Sorry for the noise, should have checked :l |
No worries |
ricardoV94
force-pushed
the
broadcast_not_a_method
branch
2 times, most recently
from
e43020c to
3a5782b
Compare
pytensor/xtensor/type.py
Outdated
| out = x[:, idx].set(1) | ||
| out.eval() | ||
| .. test-output:: |
There was a problem hiding this comment.
The output version is also without hyphen: https://www.sphinx-doc.org/en/master/usage/extensions/doctest.html#directive-testoutput. It is also hidden from the rendered output due to unrecognized directive for now
There was a problem hiding this comment.
Is there no pre-commit we could use to fail on wrong directives?
There was a problem hiding this comment.
There is the "fail on warning" rtd flag which would fail on wrong directives, things missing from toctree. If there are only a handful of warnings I can fix all the existing ones and set this up. Not sure about directives, I think I saw an rST linter once, but directives can be custom so not sure if it would catch that or simply focus on the syntax of the directve instead of the content
There was a problem hiding this comment.
Feel free to check if number of warnings is crazy, that would be useful even if it doesn't address my problem
ricardoV94
force-pushed
the
broadcast_not_a_method
branch
2 times, most recently
from
f9b6405 to
c8f9c74
Compare
Also remove broadcast which is not a method in Xarray
ricardoV94
force-pushed
the
broadcast_not_a_method
branch
from
c8f9c74 to
6ab3cbd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1533 +/- ##
==========================================
+ Coverage 81.86% 81.90% +0.04%
==========================================
Files 230 230
Lines 52508 52506 -2
Branches 9339 9339
==========================================
+ Hits 42984 43006 +22
+ Misses 7092 7070 -22
+ Partials 2432 2430 -2
🚀 New features to boost your workflow:
|
Also add docstrings to most methods and properties so they show up in the docs.
Removes broadcast as a method, since it is not one in xarray
📚 Documentation preview 📚: https://pytensor--1533.org.readthedocs.build/en/1533/