-
Notifications
You must be signed in to change notification settings - Fork 139
Add intro notebook from workshop #1585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
I actually think showing that we fully transform a forward graph |
This one fell through the cracks, let's get it merged in! We could also link to the video of the notebook being presented in the intro? https://www.youtube.com/watch?v=C1JJ33z9g00 |
Done! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1585 +/- ##
==========================================
+ Coverage 81.54% 81.69% +0.15%
==========================================
Files 230 230
Lines 53136 52950 -186
Branches 9448 9404 -44
==========================================
- Hits 43329 43260 -69
+ Misses 7370 7256 -114
+ Partials 2437 2434 -3 🚀 New features to boost your workflow:
|
I do not know why the extras are not parsing :( |
9808f46
to
1f6c1d7
Compare
Thanks for the comments @ricardoV94 ! I will come back to this one soon (I did not modify the original notebook much) |
I think I have addressed all your comments @ricardoV94 :) |
3 small notes. I think it's pretty good already so let me know if you want to integrate them or merge as is |
Thank you @ricardoV94 ! I addressed the three suggestions. Please let me know and see if I missed something 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a ton
Closes #1584
I made very few modifications to the original content.
It would be nice to have this one ready before the Euro Scipy talk :)
📚 Documentation preview 📚: https://pytensor--1585.org.readthedocs.build/en/1585/