Skip to content

Fix Py_XDECREF #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
woodruffw merged 2 commits into from
Nov 18, 2025
Merged

Fix Py_XDECREF #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2e4841
audit: fix Py_XDECREF
dalcinl Nov 18, 2025
653f8ed
audit: list of allowed symbols is no longer required
dalcinl Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions abi3audit/_audit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,6 @@

logger = logging.getLogger(__name__)

# A handpicked exclusion list of symbols that are not strictly in the limited API
# or stable ABI, but in practice always appear in ABI3-compatible code.
# Since they are not listed in CPython's `stable_abi.toml`, we maintain them here separately.
# For more information, see https://github.com/pypa/abi3audit/issues/85
# and https://github.com/wjakob/nanobind/discussions/500 .
_ALLOWED_SYMBOLS: set[str] = {
"Py_XDECREF", # not stable ABI, but defined as static inline in limited API
}


class AuditError(Exception):
pass
Expand Down Expand Up @@ -134,7 +125,7 @@ def audit(so: SharedObject, assume_minimum_abi3: PyVersion = PyVersion(3, 2)) ->
continue
# Local symbols are fine, since they are inlined functions
# from the CPython limited API.
if sym.name not in _ALLOWED_SYMBOLS and sym.visibility != "local":
if sym.visibility != "local":
non_abi3_symbols.add(sym)
except Exception as exc:
raise AuditError(f"failed to collect symbols in shared object: {exc}") from exc
Expand Down
11 changes: 1 addition & 10 deletions test/test_audit_unit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,23 +48,14 @@ def __iter__(self) -> Iterator[Symbol]:
),
],
),
SharedObject(
baseline=PyVersion(3, 10),
computed=PyVersion(3, 10),
symbols=[
Symbol("PyType_GetModule", "global"),
# This test is just to assert the existing behaviour. Py_XDECREF is never a global
# symbol and will always be local.
Symbol("Py_XDECREF", "global"),
],
),
SharedObject(
baseline=PyVersion(3, 9),
computed=PyVersion(3, 14),
symbols=[
Symbol("PyType_GetModule", "global"),
Symbol("Py_TYPE", "global"),
Symbol("Py_REFCNT", "local"),
Symbol("Py_XDECREF", "local"),
],
future_abi3_objects=[
Function(
Expand Down