Skip to content

Conversation

agriyakhetarpal
Copy link
Member

Note

This PR is not intended to be merged in its current state, and exists solely to gather feedback.

I was wondering if we could extend the CODEOWNERS file established in #2481 a little more to include some more files – in specific, the constraints files in this PR. Platform-specific constraints files could be reviewed by the platform maintainers, and the rest would be reviewed by the core team.

The GitHub documentation mentions that CODEOWNERS files accept glob patterns.

@henryiii
Copy link
Contributor

Sure, I think that was just an oversight, since the other platforms don't have them.

cibuildwheel/platforms/ios.py @freakboy3742
cibuildwheel/platforms/pyodide.py @hoodmane @ryanking13 @agriyakhetarpal
cibuildwheel/platforms/android.py @mhsmith

# Constraints files
# cibuildwheel/resources/constraints @pypa/cibuildwheel-maintainers
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# cibuildwheel/resources/constraints @pypa/cibuildwheel-maintainers
cibuildwheel/resources/constraints @pypa/cibuildwheel-maintainers

I'm unsure if this should be @pypa/cibuildwheel-maintainers or @pypa/cibuildwheel-team

@henryiii
Copy link
Contributor

One problem is this file changes a lot, including the weekly update, not sure if everyone wants a requested review every week? Especially for the general constraint file. (I don't think it would bother me, but others might care? I don't think it does much differently for me since I get notified anyway)

@agriyakhetarpal
Copy link
Member Author

Personally, I would be fine with having to review once a week. Though, I understand that if there are no changes on our end and only dependencies for Pyodide-related tooling are being updated, it won't be helpful. It could be beneficial in situations where we might publish a broken version of pyodide-build, and through this review, we could prevent it from being included in a cibuildwheel release. Still, those instances are going to be quite rare.

Especially for the general constraint file. (I don't think it would bother me, but others might care? I don't think it does much differently for me since I get notified anyway)

You are correct; it won't make a difference for the core maintainers, as I checked that all of you are watching the repository. However, the platform maintainers are not. I guess we can ask @hoodmane and @ryanking13 and see what they think!

@ryanking13
Copy link
Member

I'm fine with getting notified weekly. I can't always review quickly, but when I can't, I believe other Pyodide maintainers or cibuildwheel core developers will review and merge.

@henryiii henryiii merged commit 33b75f4 into pypa:main Aug 18, 2025
28 of 29 checks passed
@agriyakhetarpal agriyakhetarpal deleted the constraints-reviews-platform-maintainers branch August 18, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants