Skip to content

Make sure type(None) is used instead of None for the type argument of isinstance. #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2025
Merged

Make sure type(None) is used instead of None for the type argument of isinstance. #344

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90bc1cf
Make sure type(None) is used instead of None for the type argument of…
Sachaa-Thanasius Mar 12, 2025
55ccc6a
Add a regression test.
jaraco Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion distutils/compilers/C/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,8 +236,11 @@ def _check_macro_definition(self, defn):
def _is_valid_macro(name, value=None):
"""
A valid macro is a ``name : str`` and a ``value : str | None``.
>>> Compiler._is_valid_macro('foo', None)
True
"""
return isinstance(name, str) and isinstance(value, (str, None))
return isinstance(name, str) and isinstance(value, (str, type(None)))

# -- Bookkeeping methods -------------------------------------------

Expand Down
Loading