Use float value of ST_MTIME in copy_file function #379
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@Avasam Could you please approve the test workflow? |
Contributor
Whilst I have contributed to, I am not a maintainer of distutils (or setuptools). I cannot approve PRs or workflows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
copy_filefunction usesst[ST_MTIME]when copying timestamps which is an intwhereas the
newerfunction usesos.path.getmtimewhich returns a float to check ifa file is outdated. This causes the copied file to always be older than the source file.
This commit updates the
copy_filefunction to usest.st_mtimewhich is the float value.Ref: pypa/setuptools#5079