Implement --uploaded-prior-to
#13625
Conversation
notatallshaw
force-pushed
the
uploaded-prior-to
branch
from
61fa50c to
716ee0d
Compare
|
Okay, this is again ready for review or approval, though I appreciate if no one will have time before 25.3, I will move to 26.0 if it remains unmerged before release. |
notatallshaw
force-pushed
the
uploaded-prior-to
branch
from
716ee0d to
255fe19
Compare
…-time`, pass to `SubprocessBuildEnvironmentInstaller`
notatallshaw
force-pushed
the
uploaded-prior-to
branch
from
255fe19 to
38e3992
Compare
notatallshaw
force-pushed
the
uploaded-prior-to
branch
from
38e3992 to
1f6c9b8
Compare
| * ``2025-03-16 12:30:00`` - Datetime in local timezone | ||
| * ``2025-03-16T12:30:00Z`` - Datetime in UTC | ||
| * ``2025-03-16T12:30:00+05:00`` - Datetime in UTC offset |
There was a problem hiding this comment.
Just to clarify, the space vs T difference is insignificant right? It’s not entirely clear from the examples; if I’m just reading those I’d assume I need to use a space instead of T if I want the local timezone. I’d just use T for all examples and just silently support those not-actually-ISO-8601-compatible formats supported by Python’s fromisoformat.
| def parse_iso_datetime(isodate: str) -> datetime.datetime: | ||
| """Convert an ISO format string to a datetime. | ||
| Handles the format 2020-01-22T14:24:01Z (trailing Z) | ||
| which is not supported by older versions of fromisoformat. | ||
| """ | ||
| # Python 3.11+ supports Z suffix natively in fromisoformat | ||
| if sys.version_info >= (3, 11): | ||
| return datetime.datetime.fromisoformat(isodate) | ||
| else: | ||
| return datetime.datetime.fromisoformat(isodate.replace("Z", "+00:00")) |
There was a problem hiding this comment.
This introduces a weird edge case
>>> # Note: Python 3.14
>>> import datetime
>>> datetime.datetime.fromisoformat('20220101Z')
Traceback (most recent call last):
File "<python-input-1>", line 1, in <module>
datetime.datetime.fromisoformat('20220101Z')
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^
ValueError: Invalid isoformat string: '20220101Z'
>>> datetime.datetime.fromisoformat('20220101+00:00')
datetime.datetime(2022, 1, 1, 0, 0)So this non-standard value 20220101Z would parse on older Python but not newer versions. Which is technically fine (it’s non-standard), but might be slightly confusing if the user ever hit it.
Since Python 3.10 is reaching its EOL next year anyway, maybe it wouldn’t be a terrible idea to simply not support Zulu when pip is running on 3.10.x or older.
3 participants
Closes #6257
Supplants #12717 & #13520 (because I accidentally broke that PR)
Design Choices:
Option Name & Semantics - "uploaded-prior-to" was chosen to match semantically with an exclusive upper bound in both the "date" and "datetime" format, e.g.
--uploaded-prior-to 2025-01-01includes only packages uploaded prior to2025-01-01 00:00:00(i.e., 2024 and earlier): #13520 (comment)Timezone - Accepts ISO 8601 datetime strings, defaults to local timezone if unspecified. Documentation recommends explicit UTC (Z suffix) or UTC offset for reproducibility: #13520 (comment)
Error Handling - Fails immediately if a package index doesn't provide upload-time metadata. File system packages (local directories, wheels, etc.) are unaffected - this only applies to remote indexes: #13520 (comment), so you can specify local packages that depend on remote packages and filter those remote packages by