Add uploader next to author/maintainer in info json #10575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketheman
reviewed
Mar 31, 2022
There was a problem hiding this comment.
Uploader value is not guaranteed to be available, per https://github.com/pypa/warehouse/blob/bc54b9db85e331623abe8b51c5954bf1de688c59/warehouse/packaging/models.py#L477
Have you considered how to guard against that possibility?
Adding a test to cover this behavior in https://github.com/pypa/warehouse/blob/main/tests/unit/legacy/api/test_json.py
And specifically using the ReleaseFactory to create a release without an uploaded value would be the way to go.
miketheman
added
the
awaiting-response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that on https://pypi.org/project/identifier/ I can see the user "Collie" as maintainer, but on https://pypi.org/pypi/identifier/json the user cannot be seen at all.
It would be nice to be able to get the same information in a structured way as via the GUI.
I'm uncertain if the uploader email is kept confidential.