Fix: assertrepr_compare respects dict insertion order #14050
+55
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidAGInnovation
force-pushed
the
feature/pytest-unsorted-repr
branch
from
d415833 to
862ac24
Compare
psf-chronographer
bot
added
the
bot:chronographer:provided
DavidAGInnovation
force-pushed
the
feature/pytest-unsorted-repr
branch
from
862ac24 to
e1a94c1
Compare
Author
|
Hey. Can someone review it? |
nicoddemus
reviewed
Dec 27, 2025
Member
There was a problem hiding this comment.
Could you please also add an integration test like the one suggested in #14066 (comment)? Thanks!
| ) | ||
|
|
||
|
|
||
| def test_saferepr_dict_preserves_insertion_order(): |
Member
There was a problem hiding this comment.
Please add type annotations to the tests (-> None).
|
|
||
|
|
||
| def test_saferepr_dict_preserves_insertion_order(): | ||
| d = {"b": 1, "a": 2} |
Member
There was a problem hiding this comment.
Could we have more keys here just for safety?
Suggested change
| d = {"b": 1, "a": 2} | |
| d = { | |
| "b": 2, | |
| "a": 1, | |
| "d": 4, | |
| "e": 5, | |
| "c": 3, | |
| } |
| @@ -0,0 +1 @@ | |||
| Assertion comparison output now preserves dictionary insertion order instead of sorting keys. | |||
Member
There was a problem hiding this comment.
Suggested change
| Assertion comparison output now preserves dictionary insertion order instead of sorting keys. | |
| Display dictionary differences in assertion failures using the original key insertion order instead of sorted order. |
|
|
||
|
|
||
| def test_saferepr_dict_fillvalue_when_level_is_zero(): | ||
| from _pytest._io.saferepr import SafeRepr |
Member
There was a problem hiding this comment.
Please move these imports from local to global.
nicoddemus
requested changes
Dec 27, 2025
Member
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Thanks for the PR! Please take a look at my comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13503. Modified SafeRepr to override repr_dict and avoid sorting keys, ensuring that assertion failure messages preserve the user's insertion order for dictionaries.