Use canonical IANA zone names in zone_territories #1220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1220 +/- ##
=======================================
Coverage 91.97% 91.97%
=======================================
Files 27 27
Lines 4688 4688
=======================================
Hits 4312 4312
Misses 376 376
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@anentropic Please review if you have time :) |
There was a problem hiding this comment.
Pull Request Overview
Updates how timezone data is imported and tested so that the canonical IANA IDs are used for zone_territories while preserving aliases.
- Combined and extended the legacy
test_get_globalintotest_zone_aliases_and_territoriesto verify both alias and canonical lookups. - Modified
parse_globalinimport_cldr.pyto prefer theianaattribute for tzid, skip deprecated entries, and more robustly derive territory mappings. - Adjusted territory resolution to fall back through aliases rather than relying solely on the primary alias.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/test_core.py | Replaced test_get_global with a broader test covering aliases and canonical zones. |
| scripts/import_cldr.py | Updated parse_global to use iana attribute, skip deprecated, and refine territory lookup. |
|
the results in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #1218, should fix it.
There's an
iana="..."attribute in (at least recent) timezone XML files, but we historically never read that and instead just trusted the first alias to be the canonical tzid.