-
-
Couldn't load subscription status.
- Fork 68
Update pre-commit hooks #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update pre-commit hooks #407
Conversation
This was fixed mechanically using the following command: ``` pre-commit migrate-config ```
This was updated mechanically using the following command: ``` pre-commit autoupdate ```
`pyupgrade` upgrades `%` and `.format()` usage to f-strings.
Additionally, add a configuration for flake8.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #407 +/- ##
==========================================
- Coverage 92.09% 91.91% -0.19%
==========================================
Files 24 24
Lines 759 742 -17
Branches 80 83 +3
==========================================
- Hits 699 682 -17
+ Misses 42 39 -3
- Partials 18 21 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR introduces the following changes:
Fix deprecated pre-commit stage names.
When
pre-commit installis run, it currently throws a deprecation regarding the stage names in the config file. This is now fixed.Update the
pyupgradehook to its latest version, and update its target syntax version to Python 3.9+.Remove
flyntas a pre-commit hook.Its functionality is handled by the
pyupgradehook.Migrate from
localpre-commit hooks to standard, hosted pre-commit hooks.This change is necessary because not all git-related tooling runs pre-commit hooks with the same activated virtual environment that the Poetry dev dependencies are installed in.
Taken together, these changes bring the pre-commit hook configuration up-to-date, and make it possible to enable pre-commit.ci for the repo if you choose to do so (and I highly recommend doing so!).
Note
I've split the commits up so that it can be reviewed commit-by-commit. This isolates the manual and automatic changes so that they can be reviewed in smaller chunks.