Add trio implementation - step 2 #1672
Merged
+3,193
−587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaugustin
force-pushed
the
trio-step-2
branch
from
d808ec5 to
573b8bc
Compare
..._waiter is internal asyncio terminology that I don't find intuitive.
aaugustin
force-pushed
the
trio-step-2
branch
2 times, most recently
from
c7d6384 to
fa35f53
Compare
If these tests reached the point where websockets tried to send a second ping, it would loop on trying to find a payload not sent yet.
aaugustin
force-pushed
the
trio-step-2
branch
from
fa35f53 to
8289c83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges parts of #1628, continuing #1669.