Skip to content

gh-136065: Fix quadratic complexity in os.path.expandvars() #134952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 31, 2025
Merged

gh-136065: Fix quadratic complexity in os.path.expandvars() #134952

merged 7 commits into from
Oct 31, 2025
+96 −116

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented May 30, 2025 •
edited by bedevere-app bot
Loading

@serhiy-storchaka serhiy-storchaka added type-security A security issue needs backport to 3.9 needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 30, 2025
@bedevere-app bedevere-app bot mentioned this pull request May 30, 2025
Closed
@serhiy-storchaka serhiy-storchaka mentioned this pull request May 30, 2025
Closed
@serhiy-storchaka serhiy-storchaka force-pushed the expandvars-quadratic-complexity branch from f2ab255 to e3b2c85 Compare May 31, 2025 08:49
@serhiy-storchaka serhiy-storchaka requested a review from ambv June 3, 2025 15:49
@kexinoh kexinoh mentioned this pull request Jun 28, 2025
Closed
@serhiy-storchaka serhiy-storchaka changed the title gh-134873: Fix quadratic complexity in os.path.expandvars() gh-136065: Fix quadratic complexity in os.path.expandvars() Jun 28, 2025
@ambv ambv merged commit f029e8d into python:main Oct 31, 2025
46 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Oct 31, 2025

Thanks @serhiy-storchaka for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10, 3.11, 3.12, 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Oct 31, 2025

Sorry, @serhiy-storchaka and @ambv, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f029e8db626ddc6e3a3beea4eff511a71aaceb5c 3.14

@miss-islington-app
Copy link

miss-islington-app bot commented Oct 31, 2025

Sorry, @serhiy-storchaka and @ambv, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f029e8db626ddc6e3a3beea4eff511a71aaceb5c 3.13

@miss-islington-app
Copy link

miss-islington-app bot commented Oct 31, 2025

Sorry, @serhiy-storchaka and @ambv, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f029e8db626ddc6e3a3beea4eff511a71aaceb5c 3.12

@miss-islington-app
Copy link

miss-islington-app bot commented Oct 31, 2025

Sorry, @serhiy-storchaka and @ambv, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f029e8db626ddc6e3a3beea4eff511a71aaceb5c 3.11

@miss-islington-app
Copy link

miss-islington-app bot commented Oct 31, 2025

Sorry, @serhiy-storchaka and @ambv, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f029e8db626ddc6e3a3beea4eff511a71aaceb5c 3.10

@miss-islington-app
Copy link

miss-islington-app bot commented Oct 31, 2025

Sorry, @serhiy-storchaka and @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f029e8db626ddc6e3a3beea4eff511a71aaceb5c 3.9

ambv added a commit to ambv/cpython that referenced this pull request Oct 31, 2025
@serhiy-storchaka @ambv
[3.9] pythongh-136065: Fix quadratic complexity in os.path.expandvars…
8b8e68d 
…() (pythonGH-134952)

(cherry picked from commit f029e8d)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 31, 2025

GH-140839 is a backport of this pull request to the 3.9 branch.

ambv added a commit that referenced this pull request Oct 31, 2025
@ambv @serhiy-storchaka
[3.9] gh-136065: Fix quadratic complexity in os.path.expandvars() (GH…
2e6150a 
…-134952) (GH-140839)

(cherry picked from commit f029e8d)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
ambv added a commit to ambv/cpython that referenced this pull request Oct 31, 2025
@serhiy-storchaka @ambv
[3.14] pythongh-136065: Fix quadratic complexity in os.path.expandvar…
5c0bf52 
…s() (pythonGH-134952)

(cherry picked from commit f029e8d)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 31, 2025

GH-140844 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Oct 31, 2025
ambv added a commit to ambv/cpython that referenced this pull request Oct 31, 2025
@serhiy-storchaka @ambv
[3.13] pythongh-136065: Fix quadratic complexity in os.path.expandvar…
4fc2109 
…s() (pythonGH-134952)

(cherry picked from commit f029e8d)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 31, 2025

GH-140845 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 31, 2025
ambv added a commit to ambv/cpython that referenced this pull request Oct 31, 2025
@serhiy-storchaka @ambv
[3.12] pythongh-136065: Fix quadratic complexity in os.path.expandvar…
122a417 
…s() (pythonGH-134952)

(cherry picked from commit f029e8d)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 31, 2025

GH-140847 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 31, 2025
ambv added a commit to ambv/cpython that referenced this pull request Oct 31, 2025
@serhiy-storchaka @ambv
[3.11] pythongh-136065: Fix quadratic complexity in os.path.expandvar…
e717839 
…s() (pythonGH-134952)

(cherry picked from commit f029e8d)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 31, 2025

GH-140848 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Oct 31, 2025
ambv added a commit to ambv/cpython that referenced this pull request Oct 31, 2025
@serhiy-storchaka @ambv
[3.10] pythongh-136065: Fix quadratic complexity in os.path.expandvar…
2004463 
…s() (pythonGH-134952)

(cherry picked from commit f029e8d)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 31, 2025

GH-140851 is a backport of this pull request to the 3.10 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.10 only security fixes label Oct 31, 2025
ambv added a commit that referenced this pull request Oct 31, 2025
@ambv @serhiy-storchaka
[3.14] gh-136065: Fix quadratic complexity in os.path.expandvars() (G…
631ba34 
…H-134952) (GH-140844)

(cherry picked from commit f029e8d)

Co-authored-by: Serhiy Storchaka <[email protected]>
ambv added a commit that referenced this pull request Oct 31, 2025
@ambv @serhiy-storchaka
[3.12] gh-136065: Fix quadratic complexity in os.path.expandvars() (G…
c8a5f34 
…H-134952) (GH-140847)

(cherry picked from commit f029e8d)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
ambv added a commit that referenced this pull request Oct 31, 2025
@ambv @serhiy-storchaka
[3.10] gh-136065: Fix quadratic complexity in os.path.expandvars() (G…
892747b 
…H-134952) (GH-140851)

(cherry picked from commit f029e8d)

Co-authored-by: Serhiy Storchaka <[email protected]>
ambv added a commit that referenced this pull request Oct 31, 2025
@ambv @serhiy-storchaka
[3.13] gh-136065: Fix quadratic complexity in os.path.expandvars() (G…
9ab89c0 
…H-134952) (GH-140845)

(cherry picked from commit f029e8d)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
ambv added a commit that referenced this pull request Oct 31, 2025
@ambv @serhiy-storchaka
[3.11] gh-136065: Fix quadratic complexity in os.path.expandvars() (G…
5dceb93 
…H-134952) (GH-140848)

(cherry picked from commit f029e8d)

Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv Awaiting requested review from ambv

Assignees

@ambv ambv

Labels

type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serhiy-storchaka @ambv