Skip to content

gh-136156: Skip test_tempfile.test_link_tmpfile() on Android #136430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2025

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jul 8, 2025

@vstinner
Copy link
Member Author

vstinner commented Jul 8, 2025

cc @serhiy-storchaka

@vstinner
Copy link
Member Author

vstinner commented Jul 8, 2025

PR written to fix this regression: #136281 (comment)

@mhsmith
Copy link
Member

mhsmith commented Jul 8, 2025

test.support.os_helper.skip_unless_hardlink would be a simpler way of doing this, and would also avoid hiding failures caused by PermissionError on platforms where it's not expected.

@vstinner
Copy link
Member Author

vstinner commented Jul 9, 2025

test.support.os_helper.skip_unless_hardlink would be a simpler way of doing this, and would also avoid hiding failures caused by PermissionError on platforms where it's not expected.

Good idea. I updated my PR to use @skip_unless_hardlink.

@mhsmith
Copy link
Member

mhsmith commented Jul 9, 2025

!buildbot android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @mhsmith for commit c21182d 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136430%2Fmerge

The command will test the builders whose names match following regular expression: android

The builders matched are:

  • aarch64 Android PR
  • AMD64 Android PR

Copy link
Member

@mhsmith mhsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@freakboy3742: Please merge if someone else hasn't already.

@freakboy3742 freakboy3742 merged commit 92b33c9 into python:main Jul 9, 2025
41 checks passed
@vstinner vstinner deleted the test_tempfile_android branch July 9, 2025 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants