-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
Refactor: Use is_wasm32
flag for is_emscripten
or is_wasi
for generic checks
#136815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Cc @brettcannon . I'm okay with it if he is. |
@ambv says it needs to be |
Done. |
is_wasm
flag for is_emscripten
or is_wasi
for generic checksis_wasm32
flag for is_emscripten
or is_wasi
for generic checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like I can't edit the PR, so I'm asking for what looks like a redundant comment addition to be removed.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Brett Cannon <[email protected]>
I have made the requested changes; please review again. |
Thanks for making the requested changes! @brettcannon: please review the changes made to this pull request. |
Thanks, @anistark ! |
Thanks for review 🙌🏼 |
No description provided.