gh-135676: Reword the f-string (and t-string) section #137469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Blaise Pabon <[email protected]>
Co-authored-by: Adam Turner <[email protected]> Co-authored-by: Blaise Pabon <[email protected]>
bedevere-app
bot
added
awaiting core review
docs
Comment on lines
+2570
to
+2572
| >>> number = 14.3 | ||
| >>> 'number=14.3' | ||
| number=14.3 |
There was a problem hiding this comment.
This example is wrong, maybe this was intended?:
Suggested change
| >>> number = 14.3 | |
| >>> 'number=14.3' | |
| number=14.3 | |
| >>> number = 14.3 | |
| >>> f'{number=}' | |
| 'number=14.3' |
Comment on lines
+2584
to
+2585
| By default, the value of a replacement field expression is converted to | ||
| string using :func:`str`:: |
There was a problem hiding this comment.
Suggested change
| By default, the value of a replacement field expression is converted to | |
| string using :func:`str`:: | |
| By default, the value of a replacement field expression is converted to | |
| a string using :func:`str`:: |
| >>> f'{Fraction(1, 3)!s}' | ||
| For example:: | ||
|
|
||
| >>> str(one_third) |
There was a problem hiding this comment.
These example are duplicated, how about merging it all?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from #135942, this tackles the f-string section.
Much of the information was duplicated in
stdtypes.rst; this PR keeps lexical/syntactical details in Lexical Analysis and the evaluation & runtime behaviour in Standard types, with cross-references between the two.Since the t-string section only listed differences from f-strings, and the grammar for the two is equivalent, that section was moved to Standard types almost entirely.
📚 Documentation preview 📚: https://cpython-previews--137469.org.readthedocs.build/