gh-140373: Correctly emit PY_UNWIND event when generator is closed
#140767
+30
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efimov-mikhail
added
needs backport to 3.13
markshannon
approved these changes
Oct 30, 2025
|
Thanks for the review, @markshannon! Could you please merge this? Unfortunately, I don't have access to this "magic" button. Sorry, if this is not appropriate. |
|
Thanks @efimov-mikhail for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 31, 2025
…losed (pythonGH-140767) (cherry picked from commit d17f28f) Co-authored-by: Mikhail Efimov <[email protected]>
|
Sorry, @efimov-mikhail and @markshannon, I could not cleanly backport this to |
|
GH-140816 is a backport of this pull request to the 3.14 branch. |
efimov-mikhail
added a commit
to efimov-mikhail/cpython
that referenced
this pull request
Oct 31, 2025
|
GH-140821 is a backport of this pull request to the 3.13 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PY_UNWINDnot being delivered when a generator is closed/garbage collected #140373