gh-103847: fix cancellation safety of asyncio.create_subprocess_exec
#140805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumaraditya303
requested review from
1st1,
asvetlov and
willingc
as code owners
kumaraditya303
added
topic-asyncio
needs backport to 3.13
kumaraditya303
force-pushed
the
asyncio-subprocess-cancellation
branch
from
f79799a to
c8c31fd
Compare
kumaraditya303
force-pushed
the
asyncio-subprocess-cancellation
branch
from
7d3858a to
12cd899
Compare
|
I have added three tests all of which hang on main branch without this PR and manually tested that it fixes reproducers on the issue as well. |
kumaraditya303
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 56beaf2 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140805%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the cancellation safety of
asyncio.create_subprocess_exec. This is the simplest change I can think of which fixes the issue and is small enough that it can backported as well. A larger change would be rewrite some part of_UnixSubprocessTransportto make it cancellation safe but that would be a much larger change that I would be comfortable doing for 3.15 only.I plan to add some tests by end of week.