Skip to content

Remove outdated whitespace checks from patchcheck list #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove outdated whitespace checks from patchcheck list #1592

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c68e57
Remove outdated whitespace checks from patchcheck list
hugovk Jun 26, 2025
bce17df
fixup! Remove outdated whitespace checks from patchcheck list
hugovk Jun 26, 2025
b6dae46
Improve wording
hugovk Jun 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions getting-started/pull-request-lifecycle.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,10 +277,6 @@ On *Windows* (after any successful build):

The automated checklist runs through:

* Are there any whitespace problems in Python files?
(using :cpy-file:`Tools/patchcheck/reindent.py`)
* Are there any whitespace problems in C files?
* Are there any whitespace problems in the documentation?
* Has the documentation been updated?
* Has the test suite been updated?
* Has an entry under ``Misc/NEWS.d/next`` been added?
Expand All @@ -290,9 +286,8 @@ The automated checklist runs through:
* Has ``configure`` been regenerated, if necessary?
* Has ``pyconfig.h.in`` been regenerated, if necessary?

The automated checks don't actually *answer* all of these
questions. Aside from the whitespace checks, the tool is
a memory aid for the various elements that can go into
The automated checks don't actually *answer* these questions.
The tool is a memory aid for the various elements that can go into
making a complete pull request.


Expand Down
Loading