-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
PEP 777: How to Re-invent the Wheel #4036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I will also go back and update #3786 now to remove 777, and fixup the review comments there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've seen pre-published versions of the PEP and it LGTM. Other @python/pep-editors will likely provide some feedback before merging.
Rational for non-sequential numbering is here: #3786 (comment) |
The PEP has been split out into python#4036
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some wording suggestions, all optional.
Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks well done. I've made a few clarification suggestions to aid those who were not part of the discussion.
Co-authored-by: Carol Willing <[email protected]>
Co-authored-by: Carol Willing <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
See also wheelnext#3 to compress the images.
Compress images with oxipng
Co-authored-by: Jelle Zijlstra <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Carol Willing <[email protected]>
* Add PEP 778 and reserve 777 * Add Paul Moore as PEP delegate Co-authored-by: Hugo van Kemenade <[email protected]> * Add Paul Moore as PEP delegate Co-authored-by: Hugo van Kemenade <[email protected]> * Update peps/pep-0778.rst Co-authored-by: Hugo van Kemenade <[email protected]> * Remove extra underline Co-authored-by: Hugo van Kemenade <[email protected]> * Fix misspelling Co-authored-by: Hugo van Kemenade <[email protected]> * Remove PEP 777 The PEP has been split out into #4036 * Add codeowners * Remove third p from suppport Co-authored-by: Hugo van Kemenade <[email protected]> * Mark PEP 778 deferred * Apply suggestions from Barry to PEP text Co-authored-by: Barry Warsaw <[email protected]> * Fix lint error --------- Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Barry Warsaw <[email protected]>
Basic requirements (all PEP Types)
PEP has next available number,& set in filename (pep-NNNN.rst
), PR title (PEP 123: <Title of PEP>
) andPEP
headerAuthor
orSponsor
, and formally confirmed their approvalAuthor
,Status
(Draft
),Type
andCreated
headers filled out correctlyPEP-Delegate
,Topic
,Requires
andReplaces
headers completed if appropriate.github/CODEOWNERS
for the PEPStandards Track requirements
Discussions-To
andPost-History
📚 Documentation preview 📚: https://pep-previews--4036.org.readthedocs.build/pep-0777/