Skip to content

PEP 777: How to Re-invent the Wheel #4036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Oct 10, 2024
Merged

PEP 777: How to Re-invent the Wheel #4036

merged 17 commits into from
Oct 10, 2024

Conversation

emmatyping-nv
Copy link
Contributor

@emmatyping-nv emmatyping-nv commented Oct 9, 2024 •
edited by hugovk
Loading

Basic requirements (all PEP Types)

  • Read and followed PEP 1 & PEP 12
  • File created from the latest PEP template
  • PEP has next available number, & set in filename (pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) and PEP header
  • Title clearly, accurately and concisely describes the content in 79 characters or less
  • Core dev/PEP editor listed as Author or Sponsor, and formally confirmed their approval
  • Author, Status (Draft), Type and Created headers filled out correctly
  • PEP-Delegate, Topic, Requires and Replaces headers completed if appropriate
  • Required sections included
    • Abstract (first section)
    • Copyright (last section; exact wording from template required)
  • Code is well-formatted (PEP 7/PEP 8) and is in code blocks, with the right lexer names if non-Python
  • PEP builds with no warnings, pre-commit checks pass and content displays as intended in the rendered HTML
  • Authors/sponsor added to .github/CODEOWNERS for the PEP

Standards Track requirements

📚 Documentation preview 📚: https://pep-previews--4036.org.readthedocs.build/pep-0777/

@emmatyping-nv emmatyping-nv requested a review from a team as a code owner October 9, 2024 19:10
@ghost
Copy link

ghost commented Oct 9, 2024 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@emmatyping-nv
Copy link
Contributor Author

I will also go back and update #3786 now to remove 777, and fixup the review comments there.

warsaw
warsaw approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@warsaw warsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen pre-published versions of the PEP and it LGTM. Other @python/pep-editors will likely provide some feedback before merging.

@emmatyping-nv
Copy link
Contributor Author

Rational for non-sequential numbering is here: #3786 (comment)

emmatyping added a commit to emmatyping/peps that referenced this pull request Oct 9, 2024
@emmatyping
Remove PEP 777
bdf9e2d 
The PEP has been split out into python#4036
JelleZijlstra
JelleZijlstra reviewed Oct 9, 2024
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some wording suggestions, all optional.

@emmatyping-nv emmatyping-nv changed the title PEP 777: Re-inventing the wheel PEP 777: How to Re-invent the Wheel Oct 9, 2024
hugovk
hugovk reviewed Oct 9, 2024
View reviewed changes
hugovk
hugovk reviewed Oct 9, 2024
View reviewed changes
willingc
willingc reviewed Oct 9, 2024
View reviewed changes
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks well done. I've made a few clarification suggestions to aid those who were not part of the discussion.

@hugovk hugovk mentioned this pull request Oct 10, 2024
Merged
hugovk
hugovk approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

See also wheelnext#3 to compress the images.

@JelleZijlstra JelleZijlstra merged commit fd80708 into python:main Oct 10, 2024
6 checks passed
@emmatyping-nv emmatyping-nv deleted the pep-777 branch October 10, 2024 18:44
@emmatyping-nv emmatyping-nv restored the pep-777 branch October 10, 2024 18:44
gvanrossum pushed a commit to gvanrossum/peps that referenced this pull request Dec 10, 2024
@emmatyping-nv @JelleZijlstra
@hugovk @willingc @gvanrossum
PEP 777: How to Re-invent the Wheel (python#4036)
e2f388c 

Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Carol Willing <[email protected]>
warsaw added a commit that referenced this pull request Jul 9, 2025
@emmatyping @hugovk @warsaw
PEP 778: Supporting Symlinks in Wheels (#3786)
2d333a0 
* Add PEP 778 and reserve 777

* Add Paul Moore as PEP delegate

Co-authored-by: Hugo van Kemenade <[email protected]>

* Add Paul Moore as PEP delegate

Co-authored-by: Hugo van Kemenade <[email protected]>

* Update peps/pep-0778.rst

Co-authored-by: Hugo van Kemenade <[email protected]>

* Remove extra underline

Co-authored-by: Hugo van Kemenade <[email protected]>

* Fix misspelling

Co-authored-by: Hugo van Kemenade <[email protected]>

* Remove PEP 777

The PEP has been split out into #4036

* Add codeowners

* Remove third p from suppport

Co-authored-by: Hugo van Kemenade <[email protected]>

* Mark PEP 778 deferred

* Apply suggestions from Barry to PEP text

Co-authored-by: Barry Warsaw <[email protected]>

* Fix lint error

---------

Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Barry Warsaw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willingc willingc willingc left review comments

@warsaw warsaw warsaw approved these changes

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@emmatyping-nv @warsaw @JelleZijlstra @hugovk @willingc