-
-
Notifications
You must be signed in to change notification settings - Fork 198
Add energy measurements support #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
gvanrossum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR's title doesn't match what the code does (it seems to be adding a --track-energy flag).
| pyparsing==3.0.6 | ||
| # via packaging | ||
| pyperf==2.3.0 | ||
| pyperf @ file:///home/cappadokes/code/pyperf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like something you changed locally, but that should be changed back before landing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately this is somewhat tricky:
- for
--track-energyto work,pyperfshould also support energy measurements. There is no suchpyperfrelease at the moment, but we are working on it. - until then, if a user wants to use
--track-energyfrompyperformance, she must indeed use a localpyperfinrequirements.txt.
To be precise, the code both fixes the I will soon follow up with a documentation commit for clarification. I will also change the PR's name so as to contain both points. |
|
@cappadokes, please put the |
@ericsnowcurrently done. |
This PR introduces a new,
--track-energyoption for reporting energy consumption measurements instead of execution time, memory etc.ATTENTION:
--track-energyneeds changes in pyperf in order to work, sincepyperfis the real place where benchmarks are run.