Skip to content

Fix return type for name property in Credentials class. #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Fix return type for name property in Credentials class. #352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gssapi/creds.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,9 @@ def __new__(
super(Credentials, cls).__new__(cls, base_creds))

@property
def name(self) -> rnames.Name:
def name(self) -> names.Name:
"""Get the name associated with these credentials"""
return t.cast(rnames.Name,
return t.cast(names.Name,
self.inquire(name=True, lifetime=False, usage=False,
mechs=False).name)

Expand Down
2 changes: 2 additions & 0 deletions gssapi/tests/test_high_level.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@ def test_inquire(self, str_name, kwargs):

if kwargs['name']:
self.assertEqual(resp.name, self.name)
self.assertIsInstance(resp.name, gssnames.Name)
else:
self.assertIsNone(resp.name)

Expand All @@ -250,6 +251,7 @@ def test_inquire_by_mech(self, str_name, kwargs):

if kwargs['name']:
self.assertEqual(resp.name, self.name)
self.assertIsInstance(resp.name, gssnames.Name)
else:
self.assertIsNone(resp.name)

Expand Down