-
Notifications
You must be signed in to change notification settings - Fork 97
Minor design and layout tweaks #497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I’ve opened a PR with some small design changes that I believe could improve the UI. Please have a look and let me know if there’s anything you’d like me to adjust. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look great.
There are a few small issues I've noticed, it'd be great if you can fix those too.
- Take a look at the Get tickets button for smaller screens.
- The plane and the third blog tile are overlapping on larger screens. Can you move the animated elements a little above.
- The nav menu looks fine till ~750px, but after that the wrong menu is shown, can you fix that?
Cool, I’ll make those changes. One thought—do we need to keep the same navbar as the main page? Since the blog is a separate page, would it make sense to have just a single “Home” button linking back to the main page? This way, we can avoid updating the navbar here every time the main page changes. |
We should keep the navbar same. That's there in the design as well. I understand the challenge of updating the navbar every now and then but for the end user it shouldn't feel a different page. It should seem like a part of the same website. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logo on the bottom overlaps with Volunteer button for 400-750px. The rest looks good.
4729c82
to
aa32e72
Compare
@Sc0rpi0n101 I've resolved the issue you've mentioned. Do take a look. |
This PR includes the following changes: