Tentatively eliminate graph break overhead #3741
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: api [Python]
narendasan
reviewed
Aug 1, 2025
peri044
reviewed
Aug 15, 2025
Comment on lines
+223
to
+224
| self.cudagraphs_enabled = torch_tensorrt.runtime.get_cudagraphs_mode() | ||
| self.requires_unique_output = False |
Comment on lines
+397
to
+399
| # assert ( | ||
| # contiguous_inputs[i].dtype == self.input_dtypes[i] | ||
| # ), f"Dtype mismatch for {i}th input({input_name}). Expect {self.input_dtypes[i]}, got {contiguous_inputs[i].dtype}." |
Comment on lines
+550
to
+551
| if self.sync_stream: | ||
| self._engine_stream.wait_stream(self._caller_stream) |
There was a problem hiding this comment.
So if pytorch is not on default stream, both Pyt and TRT can run on same stream and outputs matched ?
There was a problem hiding this comment.
Do you know if there is a performance benefit of running Pytorch & TRT on a different stream vs (Pytorch on default and TRT on a separate stream ) ?
Comment on lines
+232
to
+233
| def set_requires_unique_output(self, requires_unique_output: bool) -> None: | ||
| self.requires_unique_output = requires_unique_output |
There was a problem hiding this comment.
what does this do ? Consider adding a docstring for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: