-
Notifications
You must be signed in to change notification settings - Fork 309
[not for land] float8 blockwise scaling training prototype using deep_gemm #2386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vkuzo
wants to merge
1
commit into
main
Choose a base branch
from
20250616_deepgemm_hack
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2386
Note: Links to docs will display an error until the docs builds have been completed. ❌ 10 New FailuresAs of commit c2115b5 with merge base 5bdc25d ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
c4df31a
to
a2a31eb
Compare
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
a2a31eb
to
c2115b5
Compare
vkuzo
added a commit
to pytorch/torchtitan
that referenced
this pull request
Jun 18, 2025
Summary: Test drive of pytorch/ao#2386, not for land Test Plan: ```bash with-proxy CONFIG_FILE="./torchtitan/models/llama3/train_configs/debug_model.toml" ./run_train.sh --model.converters float8 --model.print_after_conversion ``` Reviewers: Subscribers: Tasks: Tags:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this is a common community request, I did a test drive of how we could integrate
deep_gemm
into an e2e training workflow.deep_gemm
(https://github.com/deepseek-ai/DeepGEMM) provides the following things:What I saw:
grad_weight
: https://gist.github.com/vkuzo/6e9cacb226593f7e5f27ac5cd5e79fb1. For now, work around this by leaving the gemm to calculate grad_weight in bf16. Something is funky with how we are wrapping the 128_1_128_1 gemm.If we were to integrate this, here is the path forward:
deep_gemm
s 128_1_128_1 gemm work properly, or write our own, or just leave this matmul in bf16