Skip to content

add wrapper with dtensor handling for mxfp8 dim1 cast kernel #2552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

danielvegamyhre
Copy link
Contributor

@danielvegamyhre danielvegamyhre commented Jul 15, 2025

Copy link

pytorch-bot bot commented Jul 15, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2552

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 4 Pending

As of commit fcda719 with merge base 95d13d5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/7 branch from 3a5d3ba to 60fdd38 Compare July 15, 2025 20:31
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/8 branch from 7ce84dd to c9c6e00 Compare July 15, 2025 20:31
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 15, 2025
@danielvegamyhre danielvegamyhre added mx topic: not user facing Use this tag if you don't want this PR to show up in release notes labels Jul 15, 2025
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/7 to main July 15, 2025 23:43
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/7 July 15, 2025 23:43
@vkuzo
Copy link
Contributor

vkuzo commented Jul 16, 2025

add a test?

@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/7 to main July 16, 2025 15:25
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/8 branch from c9c6e00 to aaf8f6b Compare July 16, 2025 15:26
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/7 July 16, 2025 15:26
@danielvegamyhre
Copy link
Contributor Author

add a test?

I couldn't really add a meaningful test until these pieces were integrated into MXLinear in the subsequent PRs - where I then expanded the existing tests in test_mx_linear.py and test_mx_dtensor.py to cover both the "triton, cuda, None" options for dim1 cast kernel choice.

@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/7 to main July 16, 2025 15:32
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/7 July 16, 2025 15:33
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/7 to main July 16, 2025 16:14
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/7 July 16, 2025 16:14
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/7 to main July 16, 2025 16:18
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/8 branch from aaf8f6b to 780b1ca Compare July 16, 2025 16:18
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/7 July 16, 2025 16:19
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/7 to main July 16, 2025 16:22
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/8 branch from 780b1ca to cf2cb2b Compare July 16, 2025 16:22
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/7 July 16, 2025 16:22
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/7 to main July 16, 2025 17:19
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/7 July 16, 2025 17:19
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/7 branch from f93b1e6 to 1d3b299 Compare July 16, 2025 20:36
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/8 branch from cf2cb2b to 053ecec Compare July 16, 2025 20:36
danielvegamyhre added a commit that referenced this pull request Jul 16, 2025
stack-info: PR: #2552, branch: danielvegamyhre/stack/8
stack-info: PR: #2552, branch: danielvegamyhre/stack/8
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/7 to main July 16, 2025 20:40
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/8 branch from 053ecec to fcda719 Compare July 16, 2025 20:40
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/7 July 16, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. mx topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants