Clarifying the meaning of VERSION in AOBaseConfig #2635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2635
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
jerryzh168
added
the
topic: not user facing
vkuzo
reviewed
Jul 31, 2025
vkuzo
approved these changes
Jul 31, 2025
Summary: the VERSION means default version for child configs, it should never change. Also added test to enforce this Test Plan: python test/core/test_config.py Reviewers: Subscribers: Tasks: Tags:
jerryzh168
force-pushed
the
enforce-torchao-base-config-version
branch
from
3224632 to
829ef75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
the VERSION means default version for child configs, it should never change. Also added test to enforce this
Test Plan:
python test/core/test_config.py
Reviewers:
Subscribers:
Tasks:
Tags: