Add gpu_name as a parameter in roofline estimate utils #2657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2657
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit b0e0958 with merge base 5f3ab63 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D79415350 |
chowarfb
added a commit
to chowarfb/ao
that referenced
this pull request
Aug 1, 2025
Summary: See title, this lets us get estimates without needing to run on the hardware we're getting estimates for Differential Revision: D79415350
chowarfb
force-pushed
the
export-D79415350
branch
from
8689634 to
f9d6fe9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79415350 |
chowarfb
added a commit
to chowarfb/ao
that referenced
this pull request
Aug 1, 2025
Summary: Pull Request resolved: pytorch#2657 See title, this lets us get estimates without needing to run on the hardware we're getting estimates for Differential Revision: D79415350
chowarfb
force-pushed
the
export-D79415350
branch
from
f9d6fe9 to
73ff48f
Compare
jerryzh168
added
the
topic: not user facing
|
please fix ruff: https://github.com/pytorch/ao/actions/runs/16667190177/job/47175775067?pr=2657 see #1448 (comment) for instructions |
|
lg, +1 to making sure CI is green before landing |
chowarfb
force-pushed
the
export-D79415350
branch
from
73ff48f to
6f16d09
Compare
chowarfb
added a commit
to chowarfb/ao
that referenced
this pull request
Aug 4, 2025
Summary: See title, this lets us get estimates without needing to run on the hardware we're getting estimates for Differential Revision: D79415350
|
This pull request was exported from Phabricator. Differential Revision: D79415350 |
chowarfb
added a commit
to chowarfb/ao
that referenced
this pull request
Aug 4, 2025
Summary: Pull Request resolved: pytorch#2657 See title, this lets us get estimates without needing to run on the hardware we're getting estimates for Differential Revision: D79415350
chowarfb
force-pushed
the
export-D79415350
branch
from
6f16d09 to
a6ba71e
Compare
chowarfb
added a commit
to chowarfb/ao
that referenced
this pull request
Aug 4, 2025
Summary: See title, this lets us get estimates without needing to run on the hardware we're getting estimates for Differential Revision: D79415350
chowarfb
force-pushed
the
export-D79415350
branch
from
a6ba71e to
afd355e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79415350 |
chowarfb
force-pushed
the
export-D79415350
branch
from
afd355e to
822c596
Compare
chowarfb
added a commit
to chowarfb/ao
that referenced
this pull request
Aug 4, 2025
Summary: Pull Request resolved: pytorch#2657 See title, this lets us get estimates without needing to run on the hardware we're getting estimates for Differential Revision: D79415350
chowarfb
added a commit
to chowarfb/ao
that referenced
this pull request
Aug 4, 2025
Summary: See title, this lets us get estimates without needing to run on the hardware we're getting estimates for Differential Revision: D79415350
chowarfb
force-pushed
the
export-D79415350
branch
from
822c596 to
cf7163d
Compare
Summary: Pull Request resolved: pytorch#2657 See title, this lets us get estimates without needing to run on the hardware we're getting estimates for Differential Revision: D79415350
|
This pull request was exported from Phabricator. Differential Revision: D79415350 |
chowarfb
force-pushed
the
export-D79415350
branch
from
cf7163d to
b0e0958
Compare
vkuzo
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: See title, this lets us get estimates without needing to run on the hardware we're getting estimates for
Differential Revision: D79415350