Skip to content

[moe training] add benchmark script for moe layer #2671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025

Conversation

danielvegamyhre
Copy link
Contributor

@danielvegamyhre danielvegamyhre commented Aug 4, 2025

Stacked PRs:


[moe training] add benchmark script for moe layer

Summary

  • Add benchmarking script (with profiling) for a standalone MoE layer. This isolation makes perf analysis + optimization easier.

Copy link

pytorch-bot bot commented Aug 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2671

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job, 1 Pending, 1 Unrelated Failure

As of commit 3a73857 with merge base 1c96994 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

danielvegamyhre added a commit that referenced this pull request Aug 4, 2025
stack-info: PR: #2671, branch: danielvegamyhre/stack/29
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/29 branch from f84e278 to 45e4583 Compare August 4, 2025 14:39
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 4, 2025
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/28 to main August 4, 2025 14:52
danielvegamyhre added a commit that referenced this pull request Aug 4, 2025
stack-info: PR: #2671, branch: danielvegamyhre/stack/29
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/29 branch from 45e4583 to 3e12814 Compare August 4, 2025 14:52
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/28 August 4, 2025 14:52
@danielvegamyhre danielvegamyhre added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Aug 4, 2025
@danielvegamyhre danielvegamyhre changed the title [moe training] add benchmark script for moe layer [moe training] add benchmark script with profiling for a standalone MoE layer Aug 5, 2025
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/28 to main August 5, 2025 15:29
danielvegamyhre added a commit that referenced this pull request Aug 5, 2025
stack-info: PR: #2671, branch: danielvegamyhre/stack/29
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/29 branch from 3e12814 to 301c84f Compare August 5, 2025 15:29
@danielvegamyhre danielvegamyhre changed the title [moe training] add benchmark script with profiling for a standalone MoE layer [moe training] add benchmark script for moe layer Aug 5, 2025
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/28 August 5, 2025 15:29
@danielvegamyhre
Copy link
Contributor Author

cc @vkuzo @drisspg can you review this stack please

@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/28 to main August 5, 2025 16:17
danielvegamyhre added a commit that referenced this pull request Aug 5, 2025
stack-info: PR: #2671, branch: danielvegamyhre/stack/29
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/29 branch from 301c84f to 221f807 Compare August 5, 2025 16:17
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/28 August 5, 2025 16:17
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/28 to main August 5, 2025 23:11
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/28 August 5, 2025 23:12
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/28 to main August 5, 2025 23:44
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/28 August 5, 2025 23:44
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/28 to main August 5, 2025 23:56
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/28 August 5, 2025 23:57
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/28 to main August 6, 2025 00:00
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/28 August 6, 2025 00:00
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/28 to main August 6, 2025 00:13
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/28 August 6, 2025 00:13
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/28 to main August 6, 2025 00:56
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/28 August 6, 2025 00:56
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/28 to main August 6, 2025 01:19
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/28 August 6, 2025 01:20
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/28 to main August 6, 2025 01:36
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/29 branch from 221f807 to fad9062 Compare August 6, 2025 01:36
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/28 August 6, 2025 01:36
@@ -0,0 +1,179 @@
# Copyright (c) Meta Platforms, Inc. and affiliates.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: move to benchmarks/prototype/moe_training, to match existing location of benchmarks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, moved all moe training benchmark scripts in this PR stack there

@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/28 branch from a4b5e49 to 315cf2f Compare August 6, 2025 17:24
danielvegamyhre added a commit that referenced this pull request Aug 6, 2025
stack-info: PR: #2671, branch: danielvegamyhre/stack/29
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/29 branch from fad9062 to 241e9b7 Compare August 6, 2025 17:24
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/28 to main August 6, 2025 17:28
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/29 branch from 241e9b7 to a9e1e2f Compare August 6, 2025 17:28
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/28 August 6, 2025 17:28
danielvegamyhre added a commit that referenced this pull request Aug 6, 2025
stack-info: PR: #2671, branch: danielvegamyhre/stack/29
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/29 branch from a9e1e2f to 1163ab7 Compare August 6, 2025 21:44
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/28 to main August 6, 2025 21:44
stack-info: PR: #2671, branch: danielvegamyhre/stack/29
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/29 branch from 1163ab7 to 3a73857 Compare August 6, 2025 21:50
@danielvegamyhre
Copy link
Contributor Author

confirmed test failures unrelated to this change

@danielvegamyhre danielvegamyhre merged commit 0d93996 into main Aug 7, 2025
15 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants