Skip to content

Enforce clang for Windows builds #11159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Enforce clang for Windows builds #11159

wants to merge 1 commit into from

Conversation

jathu
Copy link
Contributor

@jathu jathu commented May 27, 2025

Summary

Test plan

CI

Copy link

pytorch-bot bot commented May 27, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11159

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Unrelated Failure

As of commit 5471408 with merge base 49805dd (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

  • pull / test-binary-size-linux-gcc / linux-job (gh) (trunk failure)
    /pytorch/executorch/kernels/portable/cpu/op_stack.cpp:129:26: error: comparison of integer expressions of different signedness: ‘size_t’ {aka ‘long unsigned int’} and ‘ssize_t’ {aka ‘long int’} [-Werror=sign-compare]

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 27, 2025
@jathu jathu added the release notes: none Do not include this in the release notes label May 27, 2025
@jathu jathu force-pushed the jathu/windows-ci-clang branch 2 times, most recently from 1743750 to 3a7b9d0 Compare May 27, 2025 23:19
@jathu jathu force-pushed the jathu/windows-ci-clang branch 9 times, most recently from 6a26082 to a3a7423 Compare June 3, 2025 14:17
@jathu jathu force-pushed the jathu/windows-ci-clang branch 4 times, most recently from 3db0529 to 735a90d Compare August 15, 2025 20:14
@jathu jathu force-pushed the jathu/windows-ci-clang branch from 735a90d to 5471408 Compare August 18, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants