-
Notifications
You must be signed in to change notification settings - Fork 622
Arm backend: Extend and fix bugs in VgfPipeline #12484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arm backend: Extend and fix bugs in VgfPipeline #12484
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12484
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit b3e6141 with merge base 07c8f0f ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Hi, could you update the description of the fix for the vgf quantization workflow to be more descriptive? Looks good otherwise! |
- Add support for passing transform_passes to VgfPipeline - Fix the vgf quantization - Enable Vgf quantization in ArmTester using VgfQuantizer. - Use tosa_version to distinguish between quantized and non-quantized paths instead of quant_stage, which may be None even under INT profile. Change-Id: Id289ecbde57556e749c0a281ce6c8a000bb6eece
07fbb94
to
1210018
Compare
Hey Adrian, could you review this patch again? Thanks! |
Failure not related |
- Add support for passing transform_passes to VgfPipeline - Fix the vgf quantization - Enable Vgf quantization in ArmTester using VgfQuantizer. - Use tosa_version to distinguish between quantized and non-quantized paths instead of quant_stage, which may be None even under INT profile. Change-Id: Id289ecbde57556e749c0a281ce6c8a000bb6eece
non-quantized paths instead of quant_stage, which may be
None even under INT profile.
Change-Id: Id289ecbde57556e749c0a281ce6c8a000bb6eece
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218