Skip to content

Lookahead decoding eager implementation #12491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2025
Merged

Lookahead decoding eager implementation #12491

merged 1 commit into from
Jul 17, 2025
+596 −3

Conversation

viveknayakatmeta
Copy link
Contributor

Summary: Implement reference lookahead decoding for CoreML implementation.

Reviewed By: sxu

Differential Revision: D78323399

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 15, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12491

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 737594d with merge base a4ac131 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 15, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78323399

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

viveknayakatmeta added a commit to viveknayakatmeta/executorch that referenced this pull request Jul 15, 2025
@viveknayakatmeta @facebook-github-bot
Lookahead decoding eager implementation (pytorch#12491)
7002d11 
Summary:

Implement reference lookahead decoding for CoreML implementation.

Reviewed By: sxu

Differential Revision: D78323399
viveknayakatmeta added a commit to viveknayakatmeta/executorch that referenced this pull request Jul 15, 2025
@viveknayakatmeta @facebook-github-bot
Lookahead decoding eager implementation (pytorch#12491)
6dc214e 
Summary:

Implement reference lookahead decoding for CoreML implementation.

Reviewed By: sxu

Differential Revision: D78323399
@viveknayakatmeta viveknayakatmeta force-pushed the export-D78323399 branch 2 times, most recently from 6dc214e to 56bae76 Compare July 15, 2025 16:39
viveknayakatmeta added a commit to viveknayakatmeta/executorch that referenced this pull request Jul 15, 2025
@viveknayakatmeta @facebook-github-bot
Lookahead decoding eager implementation (pytorch#12491)
56bae76 
Summary:

Implement reference lookahead decoding for CoreML implementation.

Reviewed By: sxu

Differential Revision: D78323399
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78323399

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78323399

viveknayakatmeta added a commit to viveknayakatmeta/executorch that referenced this pull request Jul 15, 2025
@viveknayakatmeta @facebook-github-bot
Lookahead decoding eager implementation (pytorch#12491)
3ea3404 
Summary:
Pull Request resolved: pytorch#12491

Implement reference lookahead decoding for CoreML implementation.

Reviewed By: sxu

Differential Revision: D78323399
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78323399

viveknayakatmeta added a commit to viveknayakatmeta/executorch that referenced this pull request Jul 15, 2025
@viveknayakatmeta @facebook-github-bot
Lookahead decoding eager implementation (pytorch#12491)
e6b28df 
Summary:
Pull Request resolved: pytorch#12491

Implement reference lookahead decoding for CoreML implementation.

Reviewed By: sxu

Differential Revision: D78323399
@facebook-github-bot
Copy link
Contributor

@viveknayakatmeta has imported this pull request. If you are a Meta employee, you can view this in D78323399.

viveknayakatmeta added a commit to viveknayakatmeta/executorch that referenced this pull request Jul 16, 2025
@viveknayakatmeta @facebook-github-bot
Lookahead decoding eager implementation (pytorch#12491)
a2e1aa2 
Summary: Implement reference lookahead decoding for CoreML implementation.

Reviewed By: billmguo

Test Plan:
Imported from GitHub, without a `Test Plan:` line.

Rollback Plan:

Differential Revision: D78323399

Pulled By: viveknayakatmeta
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78323399

viveknayakatmeta added a commit to viveknayakatmeta/executorch that referenced this pull request Jul 16, 2025
@viveknayakatmeta @facebook-github-bot
Lookahead decoding eager implementation (pytorch#12491)
088fec3 
Summary: Implement reference lookahead decoding for CoreML implementation.

Reviewed By: billmguo

Test Plan:
Imported from GitHub, without a `Test Plan:` line.

Rollback Plan:

Differential Revision: D78323399

Pulled By: viveknayakatmeta
viveknayakatmeta added a commit to viveknayakatmeta/executorch that referenced this pull request Jul 16, 2025
@viveknayakatmeta @facebook-github-bot
Lookahead decoding eager implementation (pytorch#12491)
cb1c1f8 
Summary: Implement reference lookahead decoding for CoreML implementation.

Reviewed By: billmguo

Test Plan:
Imported from GitHub, without a `Test Plan:` line.

Rollback Plan:

Differential Revision: D78323399

Pulled By: viveknayakatmeta
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78323399

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78323399

viveknayakatmeta added a commit to viveknayakatmeta/executorch that referenced this pull request Jul 16, 2025
@viveknayakatmeta @facebook-github-bot
Lookahead decoding eager implementation (pytorch#12491)
28cb813 
Summary:

 Implement reference lookahead decoding for CoreML implementation.

Reviewed By: sxu, billmguo

Differential Revision: D78323399
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78323399

viveknayakatmeta added a commit to viveknayakatmeta/executorch that referenced this pull request Jul 16, 2025
@viveknayakatmeta @facebook-github-bot
Lookahead decoding eager implementation (pytorch#12491)
9d60d35 
Summary:

 Implement reference lookahead decoding for CoreML implementation.

Reviewed By: sxu, billmguo

Differential Revision: D78323399
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78323399

viveknayakatmeta added a commit to viveknayakatmeta/executorch that referenced this pull request Jul 16, 2025
@viveknayakatmeta @facebook-github-bot
Lookahead decoding eager implementation (pytorch#12491)
72a7384 
Summary:

 Implement reference lookahead decoding for CoreML implementation.

Reviewed By: sxu, billmguo

Differential Revision: D78323399
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78323399

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78323399

viveknayakatmeta added a commit to viveknayakatmeta/executorch that referenced this pull request Jul 16, 2025
@viveknayakatmeta @facebook-github-bot
Lookahead decoding eager implementation (pytorch#12491)
26f7494 
Summary:

 Implement reference lookahead decoding for CoreML implementation.

Reviewed By: sxu, billmguo

Differential Revision: D78323399
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78323399

viveknayakatmeta added a commit to viveknayakatmeta/executorch that referenced this pull request Jul 16, 2025
@viveknayakatmeta @facebook-github-bot
Lookahead decoding eager implementation (pytorch#12491)
d4bed3c 
Summary:

 Implement reference lookahead decoding for CoreML implementation.

Reviewed By: sxu, billmguo

Differential Revision: D78323399
@viveknayakatmeta @facebook-github-bot
Lookahead decoding eager implementation (pytorch#12491)
737594d 
Summary:
Pull Request resolved: pytorch#12491

 Implement reference lookahead decoding for CoreML implementation.

Reviewed By: sxu, billmguo

Differential Revision: D78323399
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78323399

viveknayakatmeta added a commit to viveknayakatmeta/executorch that referenced this pull request Jul 16, 2025
@viveknayakatmeta @facebook-github-bot
Lookahead decoding eager implementation (pytorch#12491)
15868c1 
Summary:

 Implement reference lookahead decoding for CoreML implementation.

Reviewed By: sxu, billmguo

Differential Revision: D78323399
@SS-JIA SS-JIA merged commit f35de65 into pytorch:main Jul 17, 2025
99 of 103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billmguo billmguo billmguo approved these changes

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

@jackzhxng jackzhxng Awaiting requested review from jackzhxng jackzhxng is a code owner

@cccclai cccclai Awaiting requested review from cccclai cccclai is a code owner

@metascroy metascroy Awaiting requested review from metascroy metascroy is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@viveknayakatmeta @facebook-github-bot @billmguo @SS-JIA