Fixed runtime merging logics #12509
Merged
Fixed runtime merging logics #12509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12509
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 4c89c77 with merge base 986be2a ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78182279 |
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
Gasoonjia
approved these changes
Jul 15, 2025
Summary: This PR first added a missing return statement so that merge_runtime_overlapping_debug_handles now returns the updated debug_handle_to_output instead of doing nothing. Also updated the condition to use set intersection for more clearer checking of any common elements between debug_handle and existing_debug_handle. Reviewed By: Gasoonjia Differential Revision: D78182279
Juntian777
force-pushed
the
export-D78182279
branch
from
1004a61 to
4c89c77
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78182279 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This PR first added a missing return statement so that merge_runtime_overlapping_debug_handles now returns the updated debug_handle_to_output instead of doing nothing. Also updated the condition to use set intersection for more clearer checking of any common elements between debug_handle and existing_debug_handle.
Differential Revision: D78182279