Skip to content

[ET-VK] 1/n Split dispatches between multiple command buffers. Add semaphore support in command buffer. #12519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: gh/trivedivivek/121/base
Choose a base branch
from

Conversation

trivedivivek
Copy link
Contributor

@trivedivivek trivedivivek commented Jul 15, 2025

Stack from ghstack (oldest at bottom):

execute stage

Context

This following diffs aims to improve the performance of the Executorch Vulkan backend by adding a mechanism to issue multiple command buffers in prepack and execute function, so GPU work is issues while CPU is still working on issuing new work.

This Diff

Summary

This diff is the first in a series of diffs that aim to split dispatches between multiple command buffers and add semaphore support in the command buffer.

The changes in this diff include:

  • Adding a VkSemaphore parameter to the CommandBuffer constructor in vk_api/Command.cpp and vk_api/Command.h to support signaling when the command buffer has completed execution.
  • Modifying the CommandBuffer constructor in vk_api/Command.h and vk_api/Command.cpp to include the VkSemaphore parameter.
  • Updating the CommandBuffer object in api/Context.cpp to include the VkSemaphore parameter.

Differential Revision: D78282194

…maphore support in command buffer.

execute stage
## Context

This following diffs aims to improve the performance of the Executorch Vulkan backend by adding a mechanism to issue multiple command buffers in prepack and execute function, so GPU work is issues while CPU is still working on issuing new work.

## This Diff

### Summary

This diff is the first in a series of diffs that aim to split dispatches between multiple command buffers and add semaphore support in the command buffer.

The changes in this diff include:

*   Adding a `VkSemaphore` parameter to the `CommandBuffer` constructor in `vk_api/Command.cpp` and `vk_api/Command.h` to support signaling when the command buffer has completed execution.
*   Modifying the `CommandBuffer` constructor in `vk_api/Command.h` and `vk_api/Command.cpp` to include the `VkSemaphore` parameter.
*   Updating the `CommandBuffer` object in `api/Context.cpp` to include the `VkSemaphore` parameter.

Differential Revision: [D78282194](https://our.internmc.facebook.com/intern/diff/D78282194/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jul 15, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12519

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 95637b1 with merge base 46ca782 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

trivedivivek added a commit that referenced this pull request Jul 15, 2025
…maphore support in command buffer.

execute stage
## Context

This following diffs aims to improve the performance of the Executorch Vulkan backend by adding a mechanism to issue multiple command buffers in prepack and execute function, so GPU work is issues while CPU is still working on issuing new work.

## This Diff

### Summary

This diff is the first in a series of diffs that aim to split dispatches between multiple command buffers and add semaphore support in the command buffer.

The changes in this diff include:

*   Adding a `VkSemaphore` parameter to the `CommandBuffer` constructor in `vk_api/Command.cpp` and `vk_api/Command.h` to support signaling when the command buffer has completed execution.
*   Modifying the `CommandBuffer` constructor in `vk_api/Command.h` and `vk_api/Command.cpp` to include the `VkSemaphore` parameter.
*   Updating the `CommandBuffer` object in `api/Context.cpp` to include the `VkSemaphore` parameter.

Differential Revision: [D78282194](https://our.internmc.facebook.com/intern/diff/D78282194/)

ghstack-source-id: 296377516
Pull Request resolved: #12519
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 15, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78282194

…ers. Add semaphore support in command buffer."

execute stage
## Context

This following diffs aims to improve the performance of the Executorch Vulkan backend by adding a mechanism to issue multiple command buffers in prepack and execute function, so GPU work is issues while CPU is still working on issuing new work.

## This Diff

### Summary

This diff is the first in a series of diffs that aim to split dispatches between multiple command buffers and add semaphore support in the command buffer.

The changes in this diff include:

*   Adding a `VkSemaphore` parameter to the `CommandBuffer` constructor in `vk_api/Command.cpp` and `vk_api/Command.h` to support signaling when the command buffer has completed execution.
*   Modifying the `CommandBuffer` constructor in `vk_api/Command.h` and `vk_api/Command.cpp` to include the `VkSemaphore` parameter.
*   Updating the `CommandBuffer` object in `api/Context.cpp` to include the `VkSemaphore` parameter.

Differential Revision: [D78282194](https://our.internmc.facebook.com/intern/diff/D78282194/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78282194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: vulkan Changes to the Vulkan backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants