Skip to content

Fix no global destructor for strings in training modules #12521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025

Conversation

jathu
Copy link
Contributor

@jathu jathu commented Jul 15, 2025

Summary

When building with -Wglobal-constructors, the non-static strings throw an error since they don't have a global destructor. This diff fixes that.

Test plan

CI + internal build

@jathu jathu added ciflow/trunk ciflow/binaries release notes: none Do not include this in the release notes labels Jul 15, 2025
Copy link

pytorch-bot bot commented Jul 15, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12521

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Cancelled Jobs, 27 Pending, 6 Unrelated Failures

As of commit 4e571e8 with merge base abd6eff (image):

NEW FAILURE - The following job has failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 15, 2025
@jathu jathu marked this pull request as ready for review July 15, 2025 21:25
@jathu jathu requested a review from JacobSzwejbka as a code owner July 15, 2025 21:25
@jathu jathu force-pushed the jathu/training-destructor branch from 6b44728 to 2e0a4fb Compare July 15, 2025 21:43
@jathu jathu force-pushed the jathu/training-destructor branch from 2e0a4fb to 4e571e8 Compare July 15, 2025 22:25
@jathu jathu merged commit b14cb22 into main Jul 15, 2025
204 of 213 checks passed
@jathu jathu deleted the jathu/training-destructor branch July 15, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants