Skip to content

append to CMAKE_FIND_ROOT_PATH instead of setting executorch_DIR #12618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 48 commits into from
Jul 22, 2025

Conversation

swolchok
Copy link
Contributor

I think the _DIR mechanism is too low-level -- it helps find , but not any dependencies that also installed next to itself. CMAKE_PREFIX_PATH does both.

swolchok added 30 commits July 13, 2025 09:47
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
swolchok added 3 commits July 21, 2025 10:41
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Base automatically changed from gh/swolchok/521/head to main July 22, 2025 17:10
@swolchok swolchok changed the title append to CMAKE_PREFIX_PATH instead of setting executorch_DIR append to CMAKE_FIND_ROOT_PATH instead of setting executorch_DIR Jul 22, 2025
@swolchok
Copy link
Contributor Author

swolchok commented Jul 22, 2025

noting green CI. rebasing to make re-review easy. (EDIT: can't rebase with the button, sigh) @GregoryComer can you take a quick second look? I had to change from CMAKE_PREFIX_PATH to CMAKE_FIND_ROOT_PATH

[ghstack-poisoned]
@swolchok swolchok added the release notes: none Do not include this in the release notes label Jul 22, 2025
@swolchok
Copy link
Contributor Author

swolchok commented Jul 22, 2025

we had green CI prior to rebase and we know there's currently an outage, landing

can't land due to required checks failing requiring another rebase, sigh

@swolchok
Copy link
Contributor Author

merging based on previous green CI runs

@swolchok swolchok merged commit 6c4f934 into main Jul 22, 2025
98 checks passed
@swolchok swolchok deleted the gh/swolchok/517/head branch July 22, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants