append to CMAKE_FIND_ROOT_PATH instead of setting executorch_DIR #12618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Jul 21, 2025
swolchok
changed the title
|
noting green CI. rebasing to make re-review easy. (EDIT: can't rebase with the button, sigh) @GregoryComer can you take a quick second look? I had to change from CMAKE_PREFIX_PATH to CMAKE_FIND_ROOT_PATH |
GregoryComer
approved these changes
Jul 22, 2025
|
can't land due to |
swolchok
removed request for
digantdesai,
shoumikhin,
mergennachin,
SS-JIA,
cccclai,
lucylq,
JacobSzwejbka,
Gasoonjia,
jackzhxng,
mcr229,
kirklandsign and
metascroy
|
merging based on previous green CI runs |
Conarnar
pushed a commit
to Conarnar/executorch
that referenced
this pull request
Jul 25, 2025
…orch#12618) I think the <package>_DIR mechanism is too low-level -- it helps find <package>, but not any dependencies that <package> also installed next to itself. CMAKE_PREFIX_PATH does both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the _DIR mechanism is too low-level -- it helps find , but not any dependencies that also installed next to itself. CMAKE_PREFIX_PATH does both.