Skip to content

Arm backend: Make per-channel quantization default for VgfPipeline #12705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 23, 2025
Merged

Arm backend: Make per-channel quantization default for VgfPipeline #12705

merged 4 commits into from
Jul 23, 2025

Conversation

YufengShi-dudu
Copy link
Collaborator

@YufengShi-dudu YufengShi-dudu commented Jul 22, 2025 •
edited by pytorch-bot bot
Loading

Change-Id: I2aebff139b85dca15b26dba194825535beff3b02

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

@YufengShi-dudu
Arm backend: Make per-channel quantization default for VgfPipeline
3868638 
Change-Id: I2aebff139b85dca15b26dba194825535beff3b02
Signed-off-by: Yufeng Shi <[email protected]>
@YufengShi-dudu YufengShi-dudu added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Jul 22, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 22, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12705

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 42e348e with merge base 3ab7063 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 22, 2025
@YufengShi-dudu
Copy link
Collaborator Author

Need to mark the vgf tests with SkipIfNoModelConverter

@AdrianLundell AdrianLundell merged commit b9c31e5 into pytorch:main Jul 23, 2025
198 of 199 checks passed
Conarnar pushed a commit to Conarnar/executorch that referenced this pull request Jul 25, 2025
@YufengShi-dudu @Conarnar
Arm backend: Make per-channel quantization default for VgfPipeline (p…
1e7b2a4 
…ytorch#12705)

Signed-off-by: Yufeng Shi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrianLundell AdrianLundell AdrianLundell approved these changes

@Sebastian-Larsson Sebastian-Larsson Awaiting requested review from Sebastian-Larsson

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

Assignees
No one assigned
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YufengShi-dudu @AdrianLundell @facebook-github-bot