Skip to content

Conversation

@martinlsm
Copy link
Collaborator

@martinlsm martinlsm commented Dec 2, 2025

This patch moves ConvertSplitToSlicePass,
QuantizeClampArgumentsPass, RemoveGetItemPass, DecomposeBatchNormNoStatsPass to after the Q/DQ folding pass. This keeps the passes to work on node metadata instead of Q/DQ nodes.

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

This patch moves `ConvertSplitToSlicePass`,
`QuantizeClampArgumentsPass`, `RemoveGetItemPass`,
`DecomposeBatchNormNoStatsPass` to after the Q/DQ folding pass. This
keeps the passes to work on node metadata instead of Q/DQ nodes.

Signed-off-by: Martin Lindström <[email protected]>
Change-Id: Ic087b5dce77f0d617e01816694dc682e2b42fb2e
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16035

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit 7c937cf with merge base 4860984 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 2, 2025
@martinlsm
Copy link
Collaborator Author

@pytorchbot label ciflow/trunk

@martinlsm
Copy link
Collaborator Author

@pytorchbot label "partner: arm"

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Dec 2, 2025
@github-actions
Copy link

github-actions bot commented Dec 2, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@zingo zingo merged commit b23fcbd into pytorch:main Dec 4, 2025
293 of 296 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants