Ensure modified flag is returned correctly for RemovePermutesAroundElementwiseOps. #16047
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16047
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 0f34eb7 with merge base 42e3222 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 2, 2025
…ementwiseOps. (pytorch#16047) Summary: Pull Request resolved: pytorch#16047 Differential Revision: D88109865
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 2, 2025
…ementwiseOps. (pytorch#16047) Summary: Pull Request resolved: pytorch#16047 Differential Revision: D88109865
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 2, 2025
…ementwiseOps. (pytorch#16047) Summary: Pull Request resolved: pytorch#16047 Differential Revision: D88109865
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 2, 2025
…ementwiseOps. (pytorch#16047) Summary: Pull Request resolved: pytorch#16047 Differential Revision: D88109865
eigen-k
force-pushed
the
export-D88109865
branch
from
a9c2f3a to
0adc2d8
Compare
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 3, 2025
Summary: This change fixes an issue where the `RemovePermutesAroundElementwiseOps` pass was not correctly returning the modified flag to indicate whether the graph was changed during the optimization. The modified flag is crucial for the pass manager to determine if additional passes need to be run or if the optimization has reached a fixed point. Without properly returning this flag, the pass manager may not iterate correctly or may run unnecessary additional passes. Differential Revision: D88109865
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 3, 2025
Summary: This change fixes an issue where the `RemovePermutesAroundElementwiseOps` pass was not correctly returning the modified flag to indicate whether the graph was changed during the optimization. The modified flag is crucial for the pass manager to determine if additional passes need to be run or if the optimization has reached a fixed point. Without properly returning this flag, the pass manager may not iterate correctly or may run unnecessary additional passes. Differential Revision: D88109865
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 4, 2025
Summary: This change fixes an issue where the `RemovePermutesAroundElementwiseOps` pass was not correctly returning the modified flag to indicate whether the graph was changed during the optimization. The modified flag is crucial for the pass manager to determine if additional passes need to be run or if the optimization has reached a fixed point. Without properly returning this flag, the pass manager may not iterate correctly or may run unnecessary additional passes. Differential Revision: D88109865
eigen-k
force-pushed
the
export-D88109865
branch
from
0adc2d8 to
5ceb786
Compare
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 4, 2025
Summary: This change fixes an issue where the `RemovePermutesAroundElementwiseOps` pass was not correctly returning the modified flag to indicate whether the graph was changed during the optimization. The modified flag is crucial for the pass manager to determine if additional passes need to be run or if the optimization has reached a fixed point. Without properly returning this flag, the pass manager may not iterate correctly or may run unnecessary additional passes. Reviewed By: hsharma35 Differential Revision: D88109865
eigen-k
force-pushed
the
export-D88109865
branch
from
5ceb786 to
f5ee8e3
Compare
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 4, 2025
Summary: This change fixes an issue where the `RemovePermutesAroundElementwiseOps` pass was not correctly returning the modified flag to indicate whether the graph was changed during the optimization. The modified flag is crucial for the pass manager to determine if additional passes need to be run or if the optimization has reached a fixed point. Without properly returning this flag, the pass manager may not iterate correctly or may run unnecessary additional passes. Reviewed By: hsharma35 Differential Revision: D88109865
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 4, 2025
Summary: This change fixes an issue where the `RemovePermutesAroundElementwiseOps` pass was not correctly returning the modified flag to indicate whether the graph was changed during the optimization. The modified flag is crucial for the pass manager to determine if additional passes need to be run or if the optimization has reached a fixed point. Without properly returning this flag, the pass manager may not iterate correctly or may run unnecessary additional passes. Reviewed By: hsharma35 Differential Revision: D88109865
eigen-k
force-pushed
the
export-D88109865
branch
from
f5ee8e3 to
88179bb
Compare
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 5, 2025
Summary: This change fixes an issue where the `RemovePermutesAroundElementwiseOps` pass was not correctly returning the modified flag to indicate whether the graph was changed during the optimization. The modified flag is crucial for the pass manager to determine if additional passes need to be run or if the optimization has reached a fixed point. Without properly returning this flag, the pass manager may not iterate correctly or may run unnecessary additional passes. Reviewed By: hsharma35 Differential Revision: D88109865
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 5, 2025
Summary: This change fixes an issue where the `RemovePermutesAroundElementwiseOps` pass was not correctly returning the modified flag to indicate whether the graph was changed during the optimization. The modified flag is crucial for the pass manager to determine if additional passes need to be run or if the optimization has reached a fixed point. Without properly returning this flag, the pass manager may not iterate correctly or may run unnecessary additional passes. Reviewed By: hsharma35 Differential Revision: D88109865
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 5, 2025
Summary: This change fixes an issue where the `RemovePermutesAroundElementwiseOps` pass was not correctly returning the modified flag to indicate whether the graph was changed during the optimization. The modified flag is crucial for the pass manager to determine if additional passes need to be run or if the optimization has reached a fixed point. Without properly returning this flag, the pass manager may not iterate correctly or may run unnecessary additional passes. Reviewed By: hsharma35 Differential Revision: D88109865
hsharma35
approved these changes
Dec 5, 2025
Summary: This change fixes an issue where the `RemovePermutesAroundElementwiseOps` pass was not correctly returning the modified flag to indicate whether the graph was changed during the optimization. The modified flag is crucial for the pass manager to determine if additional passes need to be run or if the optimization has reached a fixed point. Without properly returning this flag, the pass manager may not iterate correctly or may run unnecessary additional passes. Reviewed By: hsharma35 Differential Revision: D88109865
eigen-k
force-pushed
the
export-D88109865
branch
from
88179bb to
0f34eb7
Compare
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 5, 2025
Summary: This change fixes an issue where the `RemovePermutesAroundElementwiseOps` pass was not correctly returning the modified flag to indicate whether the graph was changed during the optimization. The modified flag is crucial for the pass manager to determine if additional passes need to be run or if the optimization has reached a fixed point. Without properly returning this flag, the pass manager may not iterate correctly or may run unnecessary additional passes. Reviewed By: hsharma35 Differential Revision: D88109865
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 5, 2025
Summary: This change fixes an issue where the `RemovePermutesAroundElementwiseOps` pass was not correctly returning the modified flag to indicate whether the graph was changed during the optimization. The modified flag is crucial for the pass manager to determine if additional passes need to be run or if the optimization has reached a fixed point. Without properly returning this flag, the pass manager may not iterate correctly or may run unnecessary additional passes. Reviewed By: hsharma35 Differential Revision: D88109865
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D88109865