Replace duplicated RemoveCloneOpPass with RemoveCloneOpsTransformImported. #16048
+11
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16048
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 1 Unrelated FailureAs of commit a4e8b4f with merge base 42e3222 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 2, 2025
…rted. (pytorch#16048) Summary: Pull Request resolved: pytorch#16048 Differential Revision: D88109862
eigen-k
force-pushed
the
export-D88109862
branch
from
e96089f to
66d94b2
Compare
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 2, 2025
…rted. (pytorch#16048) Summary: Pull Request resolved: pytorch#16048 Differential Revision: D88109862
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 2, 2025
…rted. (pytorch#16048) Summary: Pull Request resolved: pytorch#16048 Differential Revision: D88109862
eigen-k
force-pushed
the
export-D88109862
branch
from
66d94b2 to
555e25e
Compare
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 3, 2025
…rted (pytorch#16048) Summary: This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module. Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic. Differential Revision: D88109862
DrJessop
approved these changes
Dec 3, 2025
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 4, 2025
…rted (pytorch#16048) Summary: This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module. Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic. Reviewed By: DrJessop Differential Revision: D88109862
eigen-k
force-pushed
the
export-D88109862
branch
from
555e25e to
4df0b32
Compare
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 4, 2025
…rted (pytorch#16048) Summary: This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module. Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic. Reviewed By: DrJessop Differential Revision: D88109862
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 5, 2025
…rted (pytorch#16048) Summary: This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module. Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic. Reviewed By: DrJessop Differential Revision: D88109862
eigen-k
force-pushed
the
export-D88109862
branch
from
4df0b32 to
881efcd
Compare
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 5, 2025
…rted (pytorch#16048) Summary: This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module. Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic. Reviewed By: DrJessop Differential Revision: D88109862
Summary: This change fixes an issue where the `RemovePermutesAroundElementwiseOps` pass was not correctly returning the modified flag to indicate whether the graph was changed during the optimization. The modified flag is crucial for the pass manager to determine if additional passes need to be run or if the optimization has reached a fixed point. Without properly returning this flag, the pass manager may not iterate correctly or may run unnecessary additional passes. Reviewed By: hsharma35 Differential Revision: D88109865
…rted (pytorch#16048) Summary: This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module. Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic. Reviewed By: DrJessop Differential Revision: D88109862
eigen-k
force-pushed
the
export-D88109862
branch
from
881efcd to
a4e8b4f
Compare
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 5, 2025
…rted (pytorch#16048) Summary: This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module. Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic. Reviewed By: DrJessop Differential Revision: D88109862
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D88109862