Skip to content

Conversation

@DrJessop
Copy link
Contributor

@DrJessop DrJessop commented Dec 3, 2025

Summary:
Updated

  • ReplaceSelectWithViewOpPass
  • ReplaceMMWithAddMMPass
  • ReplacePadWithCatPass
  • ReplaceTrivialConvWithLinear
  • ReplaceConvWithIm2RowAndLinear
  • ReplaceTorchQuantizedEmbeddingWithCadenceQuantizedEmbedding

to use the new more efficient RemoveOrReplacePassInterface, which also correctly sets the modified bit.

Reviewed By: hsharma35

Differential Revision: D87821616

Summary:
Updated
- ReplaceSelectWithViewOpPass
- ReplaceMMWithAddMMPass
- ReplacePadWithCatPass
- ReplaceTrivialConvWithLinear
- ReplaceConvWithIm2RowAndLinear
- ReplaceTorchQuantizedEmbeddingWithCadenceQuantizedEmbedding

to use the new more efficient RemoveOrReplacePassInterface, which also correctly sets the modified bit.

Reviewed By: hsharma35

Differential Revision: D87821616
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16063

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 36f850b with merge base 93bf861 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 3, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 3, 2025

@DrJessop has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87821616.

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

DrJessop pushed a commit to DrJessop/executorch that referenced this pull request Dec 3, 2025
Summary:

Updated
- ReplaceSelectWithViewOpPass
- ReplaceMMWithAddMMPass
- ReplacePadWithCatPass
- ReplaceTrivialConvWithLinear
- ReplaceConvWithIm2RowAndLinear
- ReplaceTorchQuantizedEmbeddingWithCadenceQuantizedEmbedding

to use the new more efficient RemoveOrReplacePassInterface, which also correctly sets the modified bit.

Reviewed By: eigen-k, hsharma35

Differential Revision: D87821616
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants