-
Notifications
You must be signed in to change notification settings - Fork 391
Disable unrunnable benchmarks cpu test #3046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3046
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Merging PR |
Thanks for taking good care of torchrl's CI @ZainRizvi Do you know if instead of disabling faulty runs we could fix them instead? The way I approach this usually is that I try to fix the CI before the release (hence the 3 monts since it was broken). A red signal in the CI tells me that that there is something to be fixed - even if it's not ideal it's better than no signal IMO. That being said I understand that this has cost implications so I don't want to push too much to keep dead CIs running, but if anything I'd prefer if we could first try to fix them before disabling (if that makes sense). |
About this, if you want to volunteer and review TorchRL's PRs just let me know! Any help is more than welcome |
Gotcha, apologies for disabling the job in that case. The runner label used is fixed to point to a legitimate runner now, and here's a PR to re-enable the job: #3048 |
Description
The benchmark_cpu job is currently unrunnable and has been so for over 3 months.
Changes are:
Motivation and Context
This buggy runner label was referenced in this PR: https://github.com/pytorch/rl/pull/2930/files#diff-1d24b39978bd364a0913d34dc491f52f4cb244e1efaf28bd0d87ebb80a73e4cdR17
Since this the job has been unable to even start, let alone run.
Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!