Skip to content

Disable unrunnable benchmarks cpu test #3046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2025
Merged

Disable unrunnable benchmarks cpu test #3046

merged 3 commits into from
Jul 8, 2025

Conversation

ZainRizvi
Copy link
Contributor

@ZainRizvi ZainRizvi commented Jul 8, 2025

Description

The benchmark_cpu job is currently unrunnable and has been so for over 3 months.

Changes are:

  1. Disables the job from being scheduled, since it's broken. I'm not deleting the code in case someone is interested in fixing it later on.
  2. Fixes the runner label used for benchmark cpu tests to a similar machine that actually exists and has the same amount of cpu/memory, which is the first step towards fixing the job

Motivation and Context

This buggy runner label was referenced in this PR: https://github.com/pytorch/rl/pull/2930/files#diff-1d24b39978bd364a0913d34dc491f52f4cb244e1efaf28bd0d87ebb80a73e4cdR17

Since this the job has been unable to even start, let alone run.

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

Copy link

pytorch-bot bot commented Jul 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3046

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 8, 2025
@ZainRizvi ZainRizvi changed the title Fix benchmarks cpu test to actually run Disable unrunnable benchmarks cpu test Jul 8, 2025
@ZainRizvi
Copy link
Contributor Author

ZainRizvi commented Jul 8, 2025

Merging PR

@ZainRizvi ZainRizvi merged commit ad9c5ee into main Jul 8, 2025
52 of 73 checks passed
@vmoens
Copy link
Collaborator

vmoens commented Jul 9, 2025

Thanks for taking good care of torchrl's CI @ZainRizvi

Do you know if instead of disabling faulty runs we could fix them instead?

The way I approach this usually is that I try to fix the CI before the release (hence the 3 monts since it was broken). A red signal in the CI tells me that that there is something to be fixed - even if it's not ideal it's better than no signal IMO. That being said I understand that this has cost implications so I don't want to push too much to keep dead CIs running, but if anything I'd prefer if we could first try to fix them before disabling (if that makes sense).

@vmoens vmoens added the CI Has to do with CI setup (e.g. wheels & builds, tests...) label Jul 9, 2025
@vmoens
Copy link
Collaborator

vmoens commented Jul 9, 2025

Time to follow the fine tradition of this repository and merge without waiting for review or CI. Yolo

About this, if you want to volunteer and review TorchRL's PRs just let me know! Any help is more than welcome

@vmoens vmoens deleted the zainr/fix-cpu-tests branch July 9, 2025 09:41
@ZainRizvi
Copy link
Contributor Author

The way I approach this usually is that I try to fix the CI before the release (hence the 3 monts since it was broken). A red signal in the CI tells me that that there is something to be fixed - even if it's not ideal it's better than no signal IMO. That being said I understand that this has cost implications so I don't want to push too much to keep dead CIs running, but if anything I'd prefer if we could first try to fix them before disabling (if that makes sense).

Gotcha, apologies for disabling the job in that case. The runner label used is fixed to point to a legitimate runner now, and here's a PR to re-enable the job: #3048

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Has to do with CI setup (e.g. wheels & builds, tests...) CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants