cache login local storage #6839
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
izaitsevfb
requested changes
Jul 2, 2025
izaitsevfb
reviewed
Jul 2, 2025
| } | ||
|
|
||
| // Clear expired or mismatched cache | ||
| localStorage.removeItem(PERMISSION_CACHE_KEY); |
izaitsevfb
reviewed
Jul 2, 2025
| } | ||
| }; | ||
|
|
||
| const clearCachedPermissionState = () => { |
izaitsevfb
reviewed
Jul 2, 2025
Comment on lines
+297
to
+305
| let newState: "sufficient" | "insufficient"; | ||
| if (response.status === 403) { | ||
| newState = "insufficient"; | ||
| } else if (!response.ok) { | ||
| // For 500 errors or other issues, also show insufficient permissions | ||
| newState = "insufficient"; | ||
| } else { | ||
| newState = "sufficient"; | ||
| } |
There was a problem hiding this comment.
Suggested change
| let newState: "sufficient" | "insufficient"; | |
| if (response.status === 403) { | |
| newState = "insufficient"; | |
| } else if (!response.ok) { | |
| // For 500 errors or other issues, also show insufficient permissions | |
| newState = "insufficient"; | |
| } else { | |
| newState = "sufficient"; | |
| } | |
| const newState = response.status === 403 || !response.ok ? "insufficient" : "sufficient"; |
There was a problem hiding this comment.
probably could be simplified further to just checking response.ok
izaitsevfb
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• auth improvements:
– localStorage-backed 30-day cache for the “does the current user have write access to pytorch/pytorch?” check.
– new /api/torchagent-check-permissions endpoint and client-side logic to call it.
– better unauthenticated / insufficient-permission screens and a “Try again” flow.