Skip to content

[BE][HUD] Create unified CommitInfo component #6920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025

Conversation

clee2000
Copy link
Contributor

@clee2000 clee2000 commented Jul 11, 2025

There's one for commit and one for PR, but they're mostly the same

Only difference I found:

  • Commit has commit title - so I added an isCommitPage param to CommitInfo (there's already one in the CommitStatus component so I figured why not)
  • data fetch in PR checks if sha is null - changed to sha && url to get the same functionality

Should have no UI changes

Copy link

vercel bot commented Jul 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
torchci ✅ Ready (Inspect) Visit Preview Jul 11, 2025 6:36pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 11, 2025
@clee2000 clee2000 marked this pull request as ready for review July 11, 2025 18:18
@clee2000 clee2000 requested a review from a team July 11, 2025 18:19
@clee2000 clee2000 merged commit 31c9785 into main Jul 17, 2025
7 checks passed
@clee2000 clee2000 deleted the csl/commit_info_component branch July 17, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants