Fix failing CI failures on Github workflow #3195
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78357214 |
SSYernar
added a commit
to SSYernar/torchrec
that referenced
this pull request
Jul 15, 2025
Summary: Removing the `settings` decorator from `test_sharded_quant_kv_zch`. This decorator is only meaningful for Hypothesis property-based tests that use `given` with generated parameters. Since `test_sharded_quant_kv_zch` is a regular unit test with fixed inputs and no `given` decorator, the `settings` decorator serves no purpose and causes CI failures. Example reference: https://github.com/pytorch/torchrec/actions/runs/16298208915/job/46025529461?pr=3193#step:15:7136 Reviewed By: jd7-tr Differential Revision: D78357214
SSYernar
force-pushed
the
export-D78357214
branch
from
7d9b798 to
08393ed
Compare
Summary: Pull Request resolved: pytorch#3195 Removing the `settings` decorator from `test_sharded_quant_kv_zch`. This decorator is only meaningful for Hypothesis property-based tests that use `given` with generated parameters. Since `test_sharded_quant_kv_zch` is a regular unit test with fixed inputs and no `given` decorator, the `settings` decorator serves no purpose and causes CI failures. Example reference: https://github.com/pytorch/torchrec/actions/runs/16298208915/job/46025529461?pr=3193#step:15:7136 Reviewed By: jd7-tr Differential Revision: D78357214
|
This pull request was exported from Phabricator. Differential Revision: D78357214 |
SSYernar
force-pushed
the
export-D78357214
branch
from
08393ed to
6e6f30d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Removing the
settingsdecorator fromtest_sharded_quant_kv_zch. This decorator is only meaningful for Hypothesis property-based tests that usegivenwith generated parameters. Sincetest_sharded_quant_kv_zchis a regular unit test with fixed inputs and nogivendecorator, thesettingsdecorator serves no purpose and causes CI failures.Example reference:
https://github.com/pytorch/torchrec/actions/runs/16298208915/job/46025529461?pr=3193#step:15:7136
Differential Revision: D78357214