Skip to content

Remove torch._running_with_deploy() from fbcode #3207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

PaliC
Copy link
Contributor

@PaliC PaliC commented Jul 18, 2025

Summary: As per https://fb.workplace.com/groups/pytorch.dev/permalink/1828123831099422 we can now safely remove “torch.is_deploy_running”. This commit does this!

Differential Revision: D78525065

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 18, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78525065

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78525065

@PaliC PaliC force-pushed the export-D78525065 branch from a87c96f to cfa89c5 Compare July 18, 2025 18:53
PaliC added a commit to PaliC/torchrec that referenced this pull request Jul 18, 2025
…handling for load_library (pytorch#3207)

Summary:
Pull Request resolved: pytorch#3207

As per https://fb.workplace.com/groups/pytorch.dev/permalink/1828123831099422 we can now safely remove “torch.is_deploy_running”. This commit does this!

Additionally we are handling RuntimeErrors while using load_library in torchrec

Differential Revision: D78525065
@PaliC PaliC force-pushed the export-D78525065 branch from cfa89c5 to 757cf39 Compare July 22, 2025 15:03
PaliC added a commit to PaliC/torchrec that referenced this pull request Jul 22, 2025
…handling for load_library (pytorch#3207)

Summary:

As per https://fb.workplace.com/groups/pytorch.dev/permalink/1828123831099422 we can now safely remove “torch.is_deploy_running”. This commit does this!

Additionally we are handling RuntimeErrors while using load_library in torchrec

Differential Revision: D78525065
PaliC added a commit to PaliC/torchrec that referenced this pull request Jul 22, 2025
…handling for load_library (pytorch#3207)

Summary:

As per https://fb.workplace.com/groups/pytorch.dev/permalink/1828123831099422 we can now safely remove “torch.is_deploy_running”. This commit does this!

Additionally we are handling RuntimeErrors while using load_library in torchrec

Differential Revision: D78525065
@PaliC PaliC force-pushed the export-D78525065 branch from 757cf39 to e912cba Compare July 22, 2025 15:04
PaliC added a commit to PaliC/torchrec that referenced this pull request Jul 22, 2025
…handling for load_library (pytorch#3207)

Summary:

As per https://fb.workplace.com/groups/pytorch.dev/permalink/1828123831099422 we can now safely remove “torch.is_deploy_running”. This commit does this!

Additionally we are handling RuntimeErrors while using load_library in torchrec

Differential Revision: D78525065
@PaliC PaliC force-pushed the export-D78525065 branch from e912cba to e04d2c1 Compare July 22, 2025 15:07
PaliC added a commit to PaliC/torchrec that referenced this pull request Jul 22, 2025
…handling for load_library (pytorch#3207)

Summary:

As per https://fb.workplace.com/groups/pytorch.dev/permalink/1828123831099422 we can now safely remove “torch.is_deploy_running”. This commit does this!

Additionally we are handling RuntimeErrors while using load_library in torchrec

Differential Revision: D78525065
@PaliC PaliC force-pushed the export-D78525065 branch from e04d2c1 to 3e6a678 Compare July 22, 2025 15:09
PaliC added a commit to PaliC/torchrec that referenced this pull request Jul 22, 2025
…handling for load_library (pytorch#3207)

Summary:

As per https://fb.workplace.com/groups/pytorch.dev/permalink/1828123831099422 we can now safely remove “torch.is_deploy_running”. This commit does this!

Additionally we are handling RuntimeErrors while using load_library in torchrec

Differential Revision: D78525065
@PaliC PaliC force-pushed the export-D78525065 branch from 3e6a678 to 6b5f15b Compare July 22, 2025 15:09
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78525065

…handling for load_library (pytorch#3207)

Summary:

As per https://fb.workplace.com/groups/pytorch.dev/permalink/1828123831099422 we can now safely remove “torch.is_deploy_running”. This commit does this!

Additionally we are handling RuntimeErrors while using load_library in torchrec

Reviewed By: nipung90

Differential Revision: D78525065
@PaliC PaliC force-pushed the export-D78525065 branch from 6b5f15b to 962bd0b Compare July 22, 2025 15:17
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78525065

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants