-
Notifications
You must be signed in to change notification settings - Fork 544
Remove torch._running_with_deploy() from fbcode #3207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was exported from Phabricator. Differential Revision: D78525065 |
This pull request was exported from Phabricator. Differential Revision: D78525065 |
PaliC
added a commit
to PaliC/torchrec
that referenced
this pull request
Jul 18, 2025
…handling for load_library (pytorch#3207) Summary: Pull Request resolved: pytorch#3207 As per https://fb.workplace.com/groups/pytorch.dev/permalink/1828123831099422 we can now safely remove “torch.is_deploy_running”. This commit does this! Additionally we are handling RuntimeErrors while using load_library in torchrec Differential Revision: D78525065
PaliC
added a commit
to PaliC/torchrec
that referenced
this pull request
Jul 22, 2025
…handling for load_library (pytorch#3207) Summary: As per https://fb.workplace.com/groups/pytorch.dev/permalink/1828123831099422 we can now safely remove “torch.is_deploy_running”. This commit does this! Additionally we are handling RuntimeErrors while using load_library in torchrec Differential Revision: D78525065
PaliC
added a commit
to PaliC/torchrec
that referenced
this pull request
Jul 22, 2025
…handling for load_library (pytorch#3207) Summary: As per https://fb.workplace.com/groups/pytorch.dev/permalink/1828123831099422 we can now safely remove “torch.is_deploy_running”. This commit does this! Additionally we are handling RuntimeErrors while using load_library in torchrec Differential Revision: D78525065
PaliC
added a commit
to PaliC/torchrec
that referenced
this pull request
Jul 22, 2025
…handling for load_library (pytorch#3207) Summary: As per https://fb.workplace.com/groups/pytorch.dev/permalink/1828123831099422 we can now safely remove “torch.is_deploy_running”. This commit does this! Additionally we are handling RuntimeErrors while using load_library in torchrec Differential Revision: D78525065
PaliC
added a commit
to PaliC/torchrec
that referenced
this pull request
Jul 22, 2025
…handling for load_library (pytorch#3207) Summary: As per https://fb.workplace.com/groups/pytorch.dev/permalink/1828123831099422 we can now safely remove “torch.is_deploy_running”. This commit does this! Additionally we are handling RuntimeErrors while using load_library in torchrec Differential Revision: D78525065
PaliC
added a commit
to PaliC/torchrec
that referenced
this pull request
Jul 22, 2025
…handling for load_library (pytorch#3207) Summary: As per https://fb.workplace.com/groups/pytorch.dev/permalink/1828123831099422 we can now safely remove “torch.is_deploy_running”. This commit does this! Additionally we are handling RuntimeErrors while using load_library in torchrec Differential Revision: D78525065
This pull request was exported from Phabricator. Differential Revision: D78525065 |
…handling for load_library (pytorch#3207) Summary: As per https://fb.workplace.com/groups/pytorch.dev/permalink/1828123831099422 we can now safely remove “torch.is_deploy_running”. This commit does this! Additionally we are handling RuntimeErrors while using load_library in torchrec Reviewed By: nipung90 Differential Revision: D78525065
This pull request was exported from Phabricator. Differential Revision: D78525065 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As per https://fb.workplace.com/groups/pytorch.dev/permalink/1828123831099422 we can now safely remove “torch.is_deploy_running”. This commit does this!
Differential Revision: D78525065