add the forge folder #1387
Merged
add the forge folder #1387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
ebsmothers
reviewed
Jul 14, 2025
Contributor
ebsmothers
left a comment
ebsmothers
left a comment
There was a problem hiding this comment.
Looks good, thanks for adding this! I have a handful of comments, but no major concerns
Comment on lines
37
to
41
| float8: Float8 = field(default_factory=Float8) | ||
| mx: MX = field(default_factory=MX) | ||
| comm: Comm = field(default_factory=Comm) | ||
| fault_tolerance: FaultTolerance = field(default_factory=FaultTolerance) | ||
| experimental: Experimental = field(default_factory=Experimental) |
Contributor
There was a problem hiding this comment.
In the spirit of starting minimal I would leave most of these out for now. Lmk if you disagree though (I am also happy to come back later and add them as needed)
Contributor
Author
There was a problem hiding this comment.
I can do that. We probably want to keep the Comm for debugging purpose. It is used in init_distributed
tianyu-l
force-pushed
the
forge
branch
2 times, most recently
from
f8f2e88 to
592a708
Compare
ebsmothers
approved these changes
Jul 16, 2025
9 tasks
ebsmothers
reviewed
Jul 18, 2025
idoh
pushed a commit
to idoh/torchtitan
that referenced
this pull request
Jul 28, 2025
depending on pytorch#1384 and pytorch#1397
bentherien
pushed a commit
to bentherien/torchtitan_
that referenced
this pull request
Aug 5, 2025
depending on pytorch#1384 and pytorch#1397
joellidin
pushed a commit
to one-covenant/torchtitan
that referenced
this pull request
Aug 8, 2025
depending on pytorch#1384 and pytorch#1397
joellidin
pushed a commit
to one-covenant/torchtitan
that referenced
this pull request
Aug 8, 2025
depending on pytorch#1384 and pytorch#1397
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depending on #1384 and #1397